Skip to content

Add --canary option to build web compilers #3536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Jun 26, 2023

Add canary option for build_web_compilers:ddc and build_web_compilers:sdk_js builders to enable canary features in DDC.

This setting is disabled by default but can be enabled by setting it to true globally:

global_options:
  build_web_compilers:ddc:
    options:
      canary: true
  build_web_compilers:sdk_js:
    options:
      canary: true

Closes: #3535

@annagrin annagrin requested review from jakemac53 and natebosch June 26, 2023 23:55
@annagrin
Copy link
Contributor Author

@natebosch @jakemac53 I had to add --canary option to ddc and sdk_js builders in web_dev_compilers, as they have to match. Is there a way to set this option in a better way - i.e for the whole set of web_dev_compilers builders?

@@ -81,6 +81,7 @@ class LazyMapping extends Mapping {

LazyMapping(this._provider);

// ignore: unreachable_from_main
Copy link
Contributor Author

@annagrin annagrin Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a new warning, wasn't sure this API is used at runtime somewhere so I hesitated to remove it:)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring it is the correct thing to do for now. It looks to me like a bug in the lint.

https://github.com/dart-lang/linter/issues/4495

@jakemac53
Copy link
Contributor

@natebosch @jakemac53 I had to add --canary option to ddc and sdk_js builders in web_dev_compilers, as they have to match. Is there a way to set this option in a better way - i.e for the whole set of web_dev_compilers builders?

You have to do them separately like you have here

Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you need this published soon go ahead and drop the -wip

@annagrin
Copy link
Contributor Author

If you need this published soon go ahead and drop the -wip

Done!

@annagrin annagrin added the publish-ignore-warnings Ignore warnings in the publish check bot label Jun 27, 2023
@annagrin annagrin merged commit 316ae9b into dart-lang:master Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
publish-ignore-warnings Ignore warnings in the publish check bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support passing arguments to ddc
3 participants