-
Notifications
You must be signed in to change notification settings - Fork 213
Add --canary option to build web compilers #3536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@natebosch @jakemac53 I had to add --canary option to ddc and sdk_js builders in web_dev_compilers, as they have to match. Is there a way to set this option in a better way - i.e for the whole set of web_dev_compilers builders? |
@@ -81,6 +81,7 @@ class LazyMapping extends Mapping { | |||
|
|||
LazyMapping(this._provider); | |||
|
|||
// ignore: unreachable_from_main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a new warning, wasn't sure this API is used at runtime somewhere so I hesitated to remove it:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignoring it is the correct thing to do for now. It looks to me like a bug in the lint.
https://github.com/dart-lang/linter/issues/4495
You have to do them separately like you have here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you need this published soon go ahead and drop the -wip
Done! |
Add
canary
option forbuild_web_compilers:ddc
andbuild_web_compilers:sdk_js
builders to enable canary features in DDC.This setting is disabled by default but can be enabled by setting it to
true
globally:Closes: #3535