Skip to content

optimize usage of observers in MDV and PolymerExpressions #12392

Closed

Description

@jmesserly

We often create observers even for silly things, e.g. observing the "value" property of a CompoundBindings. FancySyntax has even more observers. We can skip at least the PathObserver if the thing we're observing just has a ".value"

Activity

  1. sethladd commented on Sep 6, 2013

    @sethladd
    Contributor

    Still an issue?


    Removed Library-FancySyntax label.
    Added Library-PolymerExpressions label.
    Changed the title to: "optimize usage of observers in MDV and PolymerExpressions".

  2. justinfagnani commented on Sep 6, 2013

    @justinfagnani
    Contributor

    Yes

  3. sigmundch commented on Oct 7, 2013

    @sigmundch
    Member

    Added this to the M8 milestone.

  4. sigmundch commented on Oct 9, 2013

    @sigmundch
    Member

    Removed this from the M8 milestone.
    Added this to the Later milestone.

  5. jmesserly commented on Nov 1, 2013

    @jmesserly
    Author

    this is partially fixed. NodeBinding is smart about not creating yet-another-pathobserer. TemplateIterator is smarter too.

    Still work to be done:

    • PolymerExpressions is creating way too many Scopes.
    • we still create PathObservers for empty paths.
    • need another special case for "value" in PathObserver. would be nice to avoid dart:mirrors.
    • also need a special case for a single-segment path.

    Removed Library-MDV label.

  6. sigmundch commented on Nov 14, 2013

    @sigmundch
    Member

    Removed this from the Later milestone.
    Added this to the M9 milestone.

  7. clayberg commented on Nov 15, 2013

    @clayberg

    Removed this from the M9 milestone.
    Added this to the 1.1 milestone.

  8. sigmundch commented on Jan 28, 2014

    @sigmundch
    Member

    Removed this from the 1.1 milestone.
    Added this to the 1.2 milestone.

  9. anders-sandholm commented on Feb 6, 2014

    @anders-sandholm

    Removed Library-Observe label.
    Added Pkg-Observe label.

  10. jmesserly commented on May 14, 2014

    @jmesserly
    Author

    Rafael has been slowly fixing this on the observe-js/TemplateBinding/polymer-expressions side of the world, and we've been porting those changes. I'd say it's good enough at this point.


    Added Fixed label.

  11. added this to the 1.2 milestone on May 14, 2014
  12. DartBot commented on Jun 5, 2015

    @DartBot

    This issue has been moved to dart-archive/observe#30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions