Skip to content

optimize usage of observers in MDV and PolymerExpressions #12392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmesserly opened this issue Aug 12, 2013 · 11 comments
Closed

optimize usage of observers in MDV and PolymerExpressions #12392

jmesserly opened this issue Aug 12, 2013 · 11 comments
Milestone

Comments

@jmesserly
Copy link

We often create observers even for silly things, e.g. observing the "value" property of a CompoundBindings. FancySyntax has even more observers. We can skip at least the PathObserver if the thing we're observing just has a ".value"

@sethladd
Copy link
Contributor

sethladd commented Sep 6, 2013

Still an issue?


Removed Library-FancySyntax label.
Added Library-PolymerExpressions label.
Changed the title to: "optimize usage of observers in MDV and PolymerExpressions".

@justinfagnani
Copy link
Contributor

Yes

@sigmundch
Copy link
Member

Added this to the M8 milestone.

@sigmundch
Copy link
Member

Removed this from the M8 milestone.
Added this to the Later milestone.

@jmesserly
Copy link
Author

this is partially fixed. NodeBinding is smart about not creating yet-another-pathobserer. TemplateIterator is smarter too.

Still work to be done:

  • PolymerExpressions is creating way too many Scopes.
  • we still create PathObservers for empty paths.
  • need another special case for "value" in PathObserver. would be nice to avoid dart:mirrors.
  • also need a special case for a single-segment path.

Removed Library-MDV label.

@sigmundch
Copy link
Member

Removed this from the Later milestone.
Added this to the M9 milestone.

@clayberg
Copy link

Removed this from the M9 milestone.
Added this to the 1.1 milestone.

@sigmundch
Copy link
Member

Removed this from the 1.1 milestone.
Added this to the 1.2 milestone.

@anders-sandholm
Copy link
Contributor

Removed Library-Observe label.
Added Pkg-Observe label.

@jmesserly
Copy link
Author

Rafael has been slowly fixing this on the observe-js/TemplateBinding/polymer-expressions side of the world, and we've been porting those changes. I'd say it's good enough at this point.


Added Fixed label.

@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/observe#30.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants