-
Notifications
You must be signed in to change notification settings - Fork 1.7k
polymer: turn on MirrorsUsed for all polymer libs #12396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Removed Priority-Unassigned label. |
Issue #12730 has been merged into this issue. |
I've attached a very simple app with a single custom element. I don't think I use observing at all. After running pub deploy, the output JS file is 1.8MB. Attachment: |
Added this to the M7 milestone. |
Issue #12917 has been merged into this issue. |
Marked this as blocking #12917. |
so, ideally we'd add a few lines: // in package:observe // in package:polymer // in package:polymer_expressions unfortunately this doesn't work currently because mirrorsused doesn't select subtypes |
Marked this as being blocked by #13283. |
edit subject; this is a tracking bug for all Polymer.dart code that uses reflection. We should be able to compile a Polymer app in dart2js with no hints about mirrors, and code size should be small. cc @justinfagnani. |
We're making progress on implementing support for meta targets in MirrorsUsed. Try patching in https://codereview.chromium.org/26007002/ and use something like: @MirrorsUsed(metaTargets: 'Observable') |
Issue #12917 has been merged into this issue. |
Unmarked this as blocking #12917. |
Added Library-PolymerBuild label. |
(this affects observe/polymer/polymer_expressions) Removed Library-PolymerBuild label. |
Set owner to @jmesserly. |
Added Fixed label. |
This issue has been moved to dart-archive/observe#31. |
this package could benefit greatly, since it only reflects on things that are Observable
The text was updated successfully, but these errors were encountered: