Skip to content

Make sure deployed version of apps can be small with dart2js #12917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sigmundch opened this issue Aug 29, 2013 · 7 comments
Closed

Make sure deployed version of apps can be small with dart2js #12917

sigmundch opened this issue Aug 29, 2013 · 7 comments
Labels
closed-duplicate Closed in favor of an existing report
Milestone
M8

Comments

@sigmundch
Copy link
Member

  • avoid mirrors if they are not necessary
  • use MirrorUsed where possible
@sethladd
Copy link
Contributor

Added Duplicate label.
Marked as being merged into #12396.

@sigmundch
Copy link
Member Author

Oops, I should have clarified. Using @­MirrorUsed in observe is one of the steps, but we also use mirrors to load all the libraries during initialization and to register custom elements. Maybe we can use this bug to keep track of these other issues?

Added Triaged label.
Marked as being merged into #.
Marked this as being blocked by #12396.

@sethladd
Copy link
Contributor

Update on this. Using dart 0.7.1, a simple custom element compiles to 2MB with minification. I've attached the built app, if that helps.

Attachment:
deleteme7.zip (1.70 MB)

@sethladd
Copy link
Contributor

How will we know when this issue can be closed? What does "small" mean?

@sethladd
Copy link
Contributor

Marked this as blocking #13176.

@sigmundch
Copy link
Member Author

Added this to the M8 milestone.

@sigmundch
Copy link
Member Author

Added Duplicate label.
Marked as being merged into #12396.
Unmarked this as being blocked by #12396.

@sigmundch sigmundch added Type-Defect closed-duplicate Closed in favor of an existing report labels Oct 9, 2013
@sigmundch sigmundch added this to the M8 milestone Oct 9, 2013
@sethladd sethladd mentioned this issue Jun 3, 2015
Closed
@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-duplicate Closed in favor of an existing report
Projects
None yet
Milestone
M8
Development

No branches or pull requests
3 participants
@sethladd @kevmoo @sigmundch