Skip to content

Wrong icon for editor on windows #13041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stevemessick opened this issue Sep 4, 2013 · 9 comments
Closed

Wrong icon for editor on windows #13041

stevemessick opened this issue Sep 4, 2013 · 9 comments
Assignees
Labels
P3 A lower priority bug or feature request
Milestone

Comments

@stevemessick
Copy link
Contributor

After installing the newest version the icon on the windows8 startmenu (big tiles) is showing the eclipse icon instead of the dart icon. (The dart icon does appear on the file explorer, so i'm puzzeled)
////////////////////////////////////////////////////////////////////////////////////
Editor: 0.6.21_r26639 (2013-08-26)
OS: Windows 8 - amd64 (6.2)
JVM: 1.7.0_25

projects: 3

open dart files: 3

auto-run pub: true
localhost resolves to: 127.0.0.1
mem max/total/free: 889 / 260 / 141 MB
thread count: 25
index: 166865 relationships in 37174 keys in 156 sources

SDK installed: true
Dartium installed: true

@devoncarew
Copy link
Member

Removed this from the M7 milestone.
Added this to the Later milestone.

@DartBot
Copy link

DartBot commented Mar 8, 2014

This comment was originally written by [email protected]


See issue #16056. These are probably duplicates.

@clayberg
Copy link

clayberg commented Apr 9, 2014

cc @devoncarew.
cc @danrubel.
Set owner to @scheglov.
Removed this from the Later milestone.
Added this to the 1.4 milestone.
Removed Priority-Medium label.
Added Priority-Low label.

@clayberg
Copy link

clayberg commented Apr 9, 2014

Issue #16056 has been merged into this issue.

@clayberg
Copy link

clayberg commented Apr 9, 2014

Issue #15706 has been merged into this issue.

@scheglov
Copy link
Contributor

I don't have and want have Windows8.
Works for me on Windows7.
So, it should be a bug / incompatibility in Windows8.


Added NotPlanned label.

@DartBot
Copy link

DartBot commented Apr 15, 2014

This comment was originally written by @Fox32


It's not a Windows bug, it's a wrong icon in the DartEditor.exe file. If you open it with a resource editor (or Visual Studio as a "resource file") you will see that the contained 256x256 32bit icon is actually a Eclipse icon and not a Dart one (the other sizes are Dart icons). The icon with the right size is in the repository, but maybe not referenced?

It should be reproduciably even unter Windows 7 in the following way: Switch between the different Icon sizes while viewing the exe file in Windows Explorer.

I would try it and send in a patch myself, but setting up the whole development environment is not worth the effort...

@scheglov
Copy link
Contributor

Ah.. it's an interesting effect to see how Dart icon changes to Eclipse one :-)
I think this problem is actually fixed now.
Yesterday we landed a CL with bigger and better icons and window images for Dart Editor.

So, it the new version shows Dart icon is always displayed for me.

Try the latest build.
http://gsdview.appspot.com/dart-archive/channels/be/raw/latest/editor/


Added Fixed label.

@DartBot
Copy link

DartBot commented Apr 15, 2014

This comment was originally written by @Fox32


Seems to work with that build, thanks!

@stevemessick stevemessick added Type-Defect P3 A lower priority bug or feature request labels Apr 15, 2014
@stevemessick stevemessick added this to the 1.4 milestone Apr 15, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 A lower priority bug or feature request
Projects
None yet
Development

No branches or pull requests

5 participants