Need API for creating private symbols w/r/t a given library

[rmacnak-google]

Symbol LibraryMirror.createSymbol(String)?

[peter-ahe-google]

This is somewhat iffy, but we do like to use constant symbols, so we could say:

Symbol LibraryMirror.createSymbol(Symbol)

If the given symbol doesn't start with an underscore, it is added.

So this would work:

myLibraryMirror.createSymbol(#_privateName);
myLibraryMirror.createSymbol(#privateName);
myLibraryMirror.createSymbol(new Symbol('privateName'));

[rmacnak-google]

Our current thinking is LibraryMirror.createSymbol() should take a string and emit the same warning(hint?) as new Symbol.

[anders-sandholm]

Added Area-Library label.

[peter-ahe-google]

In order for my suggestion to make sense, the method should be renamed to createPrivateSymbol.

I discussed this method with Ryan, and we both agreed it would be nicer if you could pass in strings. However, then dart2js needs to warn (as it does for new Symbol). However, dart2js cannot reliably warn about instance methods (due to optional types). So I would prefer a static method on MirrorSystem.

[floitschG]

wrt comment #­1: createPrivateSymbol(#_privateName) and createPrivateSymbol(#privateName) should not return the same symbol.

It is perfectly legal to have private variables "___foo", and it should be clear how to construct a symbol for it.

wrt comment #­4: I currently don't see the big advantage of using strings (after all it's just a new Symbol(string) away), but even with symbols we would need to track the symbols or always assume that the private version of a symbol exists too.

Personally I prefer instance methods, but I can understand if that won't work here.

[jmesserly]

Marked this as blocking #13559.

[jmesserly]

Marked this as blocking #13881.

[rmacnak-google]

MirrorSystem.getSymbol added in r28551

---

Added Fixed label.

[jmesserly]

is there a dart2js bug for this?
just in case, I filed:
https://code.google.com/p/dart/issues/detail?id=14231

(when only one side is fixed, we can't use it yet from library code, so I need a new bug # to mark things blocked against.)

[DartBot]

This comment was originally written by [email protected]

---

MirrorSystem.getSymbol("foo") will always throw an ArgumentError, I assume line 49 should be:

if ((library != null && library is! LibraryMirror) ||

48 /* patch */ static Symbol getSymbol(String name, [LibraryMirror library]) {
49 if (library is! LibraryMirror ||
50 ((name[0] == '_') && (library == null))) {
51 throw new ArgumentError(library);
52 }
53 if (library != null) name = _mangleName(name, library._reflectee);
54 return new _symbol_dev.Symbol.unvalidated(name);
55 }

[peter-ahe-google]

We shouldn't check the type, that's what checked mode is for.

[rmacnak-google]

Greg, yes.

Peter, I still want to check the type before handing things off to a primitive where it would hit an assertion error and crash rather than throw a runtime error. (Say you passed a ClassMirror instead of a LibraryMirror, which also has a reflectee which is a MirrorReference, but which has the wrong VM object inside.)

https://codereview.chromium.org/61753019/

[peter-ahe-google]

I can implement LibraryMirror myself. You need to find a different way to protect native code.