Skip to content

Total sample depends on linux build paths to dartc #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DartBot opened this issue Jan 26, 2012 · 1 comment
Closed

Total sample depends on linux build paths to dartc #1354

DartBot opened this issue Jan 26, 2012 · 1 comment
Labels
area-samples (deprecated) Deprecated: this label is no longer actively used.

Comments

@DartBot
Copy link

DartBot commented Jan 26, 2012

This issue was originally filed by [email protected]


The server infrastructure of Total re-generates the client JS code
on the fly by invoking dartc. There are 2 issues with this:

  1. Some people might want to use frog
  2. The path specified is Linux specific - running on a mac requires a different path.

One idea is to take the auto-regeneration feature out and replace it with a mechanism that compiles the client code once before the server is started. Another is to make the server flexible enough to support frog or dartc, and support them on differnt environments.

I think we are touting the dart editor for a compile/edit/debug cycle, so what I'm going to do first is try that out and document it. If that works, then I'll remove the compile meechanism from the server.

@DartBot
Copy link
Author

DartBot commented Feb 27, 2012

This comment was originally written by [email protected]


Added Fixed label.

@DartBot DartBot added Type-Defect area-samples (deprecated) Deprecated: this label is no longer actively used. labels Feb 27, 2012
copybara-service bot pushed a commit that referenced this issue Dec 18, 2024
This is a minor change with just bug fixes:

* Handle trailing commas in for-loop updaters (#1354).
* Format `||` patterns like fallthrough cases in switch expressions (#1602).
* Handle comments and metadata before variables more gracefully (#1604).
* Ensure comment formatting is idempotent (#1606).
* Better indentation of leading comments on property accesses in binary operator
  operands (#1611).
* Don't crash on doc comments in local variable declarations (#1621).

This won't affect much code, but it does change the formatting in some cases.

Change-Id: I2d52fee92aecbc24315e4f1a89360af85ec85942
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401482
Auto-Submit: Bob Nystrom <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-samples (deprecated) Deprecated: this label is no longer actively used.
Projects
None yet
Development

No branches or pull requests

1 participant