Skip to content

private method event handlers don't work in dart2js #13559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevmoo opened this issue Sep 24, 2013 · 6 comments
Closed

private method event handlers don't work in dart2js #13559

kevmoo opened this issue Sep 24, 2013 · 6 comments
Labels
closed-duplicate Closed in favor of an existing report

Comments

@kevmoo
Copy link
Member

kevmoo commented Sep 24, 2013

I've created custom elements with private event handlers

<input id='search_input' type="text" class="form-control"
  on-key-up="_searchKeyUp" placeholder="Search or Create"
  value="{{ controller.searchTerm }}">

void _searchKeyUp(KeyboardEvent e, dynamic detail, Node target) { ... }

* Works fine run directly in Dartium.

  • Lint and deploy work great.
  • The built output also runs fine in Dartium

* Compiling to JS and running in Chrome is the first time I get errors about private event handlers

Would be great to be warned earlier

@jmesserly
Copy link

uh, if it works in dartium and fails in dart2js, it means there's a bug somewhere. We shouldn't be adding code to warn about bugs in other parts of the system, we should fix the bugs :)

* Compiling to JS and running in Chrome is the first time I get errors about private event handlers

what errors?


Removed Library-Polymer label.
Added Area-Polymer, NeedsInfo labels.

@jmesserly
Copy link

Changed the title to: "private method event handlers don't work in dart2js".

@jmesserly
Copy link

hmmm, did some more digging and I think this is due to #­13355

good catch Kevin!


Marked this as being blocked by #13355.

@jmesserly
Copy link

Added Triaged label.

@sigmundch
Copy link
Member

Added this to the Later milestone.
Added Library-Polymer label.

@jmesserly
Copy link

Added Duplicate label.
Marked as being merged into #13881.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-duplicate Closed in favor of an existing report
Projects
None yet
Development

No branches or pull requests

3 participants