-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Modify dart:isolate tests to run on Dartium #13921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Actually, this breaks many more tests in the unittest package and elsewhere. See: https://codereview.chromium.org/26616002/ cc @ricowind. |
Special casing the running of certain tests in the test controller because the tests are wrongly written seems like a bad idea to me. Is anything preventing us from simply fixing up the tests? cc @mkustermann. |
So Florian actually have a cl pending: |
Added Library-Isolate label. |
Marked this as being blocked by #17649. |
Dartium is dead (woohoo!). Closing. |
We no longer support spawnFunction from the DOM isolate on Dartium. Instead, spawnUri must be used to create a background isolate (which cannot access dart:html). spawnFunction may be used from background isolates.
The following tests now fail on Dartium. We should consider either:
(a) Modifying the tests to use spawnUri
(b) Running them automatically in a background isolate (in the test framework?)
browser/compute_this_script_browser_stream_test: Fail
browser/compute_this_script_browser_test: Fail
count_stream_test: Fail
count_test: Fail
cross_isolate_message_test: Fail
global_error_handler2_test: Fail
global_error_handler_stream2_test: Fail
global_error_handler_stream_test: Fail
global_error_handler_test: Fail
illegal_msg_stream_test: Fail
illegal_msg_test: Fail
isolate_complex_messages_stream_test: Fail
isolate_complex_messages_test: Fail
mandel_isolate_stream_test: Fail
mandel_isolate_test: Fail
message2_test: Fail
message_stream2_test: Fail
message_stream_test: Fail
message_test: Fail
mint_maker_test: Fail
nested_spawn2_test: Fail
nested_spawn_stream_test: Fail
nested_spawn_test: Fail
request_reply_test: Fail
spawn_function_custom_class_test: Fail
spawn_function_test: Fail
stacktrace_message_test: Fail
unresolved_ports_test: Fail
The text was updated successfully, but these errors were encountered: