-
Notifications
You must be signed in to change notification settings - Fork 1.7k
provide a simple and uniform way to build projects #15859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
cc @kevmoo. |
This comment was originally written by @butlermatt I think the build.dart also provides some great extra functionality, but as with Issue #15146 I think it's a bit of a misnomer. I've been thinking on ways I might be able to use build.dart to setup continuous testing from the editor. But as mentioned as an open issue it can still be used for linting and (for the time being) some building as well. |
Set owner to @keertip. |
This comment was originally written by @Emasoft This issue is connected to another issue I opened some times ago: https://code.google.com/p/dart/issues/detail?id=15561 We need to reduce complexity. Not only there are 4 ways to run an example, but the user must try a dozen html files before finding the right one to launch. |
Marked this as being blocked by #15829. |
Bumping to high, should be done for the 1.2 release. Removed Priority-Medium label. |
An update on this issue In the editor we now have (a) Run html directly in Dartium We do not have cc @sethladd. |
I don't think option (c) is necessary to expose through the editor. |
but my guess is that pub-serve should be (which would be equivalent to option (c)). |
Yes, probably both of these will go through "pub serve" once we have everything in place for editor integration there. |
Agree with Nathan, (a) and (b) are P0. (c) can be solved by pub serve. |
This comment was originally written by [email protected] pub build too slow. how to speed up? |
This comment was originally written by [email protected] Please provide pub build option to compile only run on dartium, just like pub serve but not serve editor http server. |
Joo, you might want to open a separate issue request for your comment 17. That way it won't get lost. |
Run as Javascript now uses pub serve, and so speed (pub build) should no longer be an issue. |
[-- I'm creating this as an umbrella issue, to collect all of our ideas in this area. Not everything here is an editor issue, some things might have to be fixed in pub or in packages. I couldn't find if there was a bug for this already, if so, sorry for the duplicate --]
Now that we have pub-build, some of the processes for building from the editor are no longer necessary, and are starting to become confusing to our users. It would be great to get to a point where there is just one way to build, one way to lint, and one way to debug.
Take a look at this discussion for some background
https://groups.google.com/a/dartlang.org/d/msg/web/f-D1xdeK_Wk/5I0g85VhiFEJ
Some highlights: A user understands that there are at least 4 ways to run an example:
(1) Select the html file directly and "Run in Dartium"
(2) Select the html file directly and "Run as Javascript"
(3) Build and then select the corresponding file under build and "Run in Dartium"
(4) Build and then select the corresponding file under build and "Run as Javascript"
Turns out that the way things work (2) is broken (it doesn't run pub-build), and (3) doesn't work because by default pub-build doesn't output the dart implementation.
I proposed in that thread that we might want something closer to 3 ways to run an example:
(a) Run html directly in Dartium (no compilation, in the future maybe use 'pub serve'?)
(b) Run html as Javascript by doing any necessary compilation via pub-build (compile with 'pub build --mode=release')
(c) Run html compiled with pub-build in Dartium (compile with 'pub build --mode=debug')
where: (a) is like (1) and works today. (b) is like (2) and (4) and could be done today if we fix issue #14836, (c) would be a working version of (3).
There are many open questions still. Here are some I can think of:
- Run-as-Javascript was nice because you could run it on demand on a single file. Can we get to the point where pub-build supports that?
- build.dart is still in use for linting - can we do something with pub-build (maybe pub-lint?) to get that information in a uniform way?
The text was updated successfully, but these errors were encountered: