Missing setter implementation in html_dart2js.

[johnniwinther]

Many classes in html_dart2js do not implement the setter method implicitly defined by a field in implemented interface. For instance:

sdk/lib/html/dart2js/html_dart2js.dart:91:1: Warning: 'HtmlElement' doesn't implement the setter 'nextElementSibling' declared in 'ChildNode'.
Try adding an implementation of 'nextElementSibling' or declaring 'HtmlElement' to be 'abstract'.
class HtmlElement extends Element native "HTMLElement" {
^^^^^
sdk/lib/html/dart2js/html_dart2js.dart:2122:11: Info: The setter 'nextElementSibling' is implicitly declared by this field in class 'ChildNode'.
  Element nextElementSibling;
          ^^^^^^^^^^^^^^^^^^

See the attached file for all warnings.

---

Attachment:
temp.log (466.79 KB)

[johnniwinther]

The files svg_dart2js.dart and html_common/lists.dart are also affected. And some warnings are caused by other override related issue. Again, se the (previously) attached file for details.

The warnings will be generated by dart2js when CL https://codereview.chromium.org/140803002 is landed.

[blois]

Fixed with https://codereview.chromium.org//140903003

---

Set owner to @blois.
Added Fixed label.

[johnniwinther]

Reopening. Still a lot of warnings. See attached file for details.

---

Attachment:
temp.log (22.35 KB)

---

Added Triaged label.

[kasperl]

This seems important to get fixed for the 1.2 release.

---

Added this to the 1.2 milestone.

[blois]

Emily- is this something you could take a look at?

---

Set owner to @efortuna.

[efortuna]

I'll take a look

[DartBot]

This comment was originally written by ricow@chromium.org

---

Emily: you can remove the line suppressing this from being run on the analyzer in tests/lib/analyzer/analyze_library.status to validate that this is actually warning free.

[johnniwinther]

@efortuna: Update and run tests/compiler/dart2js/analyze_api_test.dart to validate that dart2js sees no more problems.

[kasperl]

Issue #16778 has been merged into this issue.

[kasperl]

Fixed in r32641 but reverted again in r32642.

[efortuna]

Fixed in r32678 with patchset https://codereview.chromium.org//164743003

---

Added Fixed label.