polymer application compilation error #18481
Comments
|
Hi! It seems that there are 3 issues: a) import to 'dart:mirrors' - I presume this is just something you do in your app? Note that we are careful to remove all uses of mirrors in the generated code of polymer applications to reduce the size of the compiled application. You might want to be careful on how you use mirrors and annotate them with @MirrorsUsed to make sure your app doesn't explode in size. b) _highlightChanged: looks like you have an event handler that is private. This is currently not supported. We report warnings on some cases like this, but it might be that we are not covering all cases. For example, I think we report this if you have a private field annotated with @published, but we don't necessarily do this for private methods. We should fix that, but meanwhile you can workaround this issue by making the method public. I filed issue #18490 for this. c) smoke_9.T: you probably have a custom element that uses a type-parameter <T>, this seems to be confusing our compiler tool. We also need to fix that, but meanwhile if you remove the type annotation (just make the field dynamic), the compilation should hopefully work. I filed issue #18491 for this. If there is something else I missed, let me know. Added Area-Polymer, Triaged labels. |
|
This comment was originally written by [email protected] thanks for the clarification! I will try the suggested workaround. regarding using of 'dart:mirrors'. I don't use import to mirrors explicit in my code.. I don't understand why there is "This import is not annotated with @MirrorsUsed, which may lead to unnecessarily large generated code..." message. |
|
This comment was originally written by [email protected] I have starred both issues 18490 and 18491 |
|
regarding "dart:mirrors" - interesting. It's pretty strange that the message above has no location of where that warning is coming from. I wonder if this is a false positive warning from dart2js, in which case we might want to get more data.
|
|
This comment was originally written by [email protected] This is full dart2js output. Later I can send an example of my code. [Warning from polymer (Linter) on od_web|web/profile_container.html]: 286 methods retained for use by dart:mirrors out of 1874 total methods (15%). 290 methods retained for use by dart:mirrors out of 1990 total methods (15%). 288 methods retained for use by dart:mirrors out of 1938 total methods (15%). 288 methods retained for use by dart:mirrors out of 1942 total methods (15%). 302 methods retained for use by dart:mirrors out of 1906 total methods (16%). 280 methods retained for use by dart:mirrors out of 2164 total methods (13%). This import is not annotated with @MirrorsUsed, which may lead to unnecessarily large generated code. 294 methods retained for use by dart:mirrors out of 2026 total methods (15%). 'smoke_8' has no member named 'T'. Not a compile-time constant. 319 methods retained for use by dart:mirrors out of 2187 total methods (15%). 321 methods retained for use by dart:mirrors out of 2199 total methods (15%). 'smoke_9' has no member named 'T'. Not a compile-time constant. 'smoke_15' has no member named 'T'. 'smoke_15' has no member named 'T'. Not a compile-time constant. Symbol literal '#_hightlightChanged' is currently unsupported by dart2js. 'smoke_14' has no member named 'T'. Symbol literal '#_hightlightChanged' is currently unsupported by dart2js. Symbol literal '#_hightlightChanged' is currently unsupported by dart2js. Symbol literal '#_hightlightChanged' is currently unsupported by dart2js. Not a compile-time constant. |
|
This comment was originally written by [email protected] If you see something which could be improved please let me know :) |
|
I see. Yes, you can see that the error about mirrors comes from using the "reflection" package. This import is not annotated with @MirrorsUsed, which may lead to unnecessarily large generated code. Depending on what you use reflection for, you could add a @MirrorsUsed annotation to override the default behavior of this import. By default dart2js will keep around lots of symbols assuming that you can reflectively access anything in your code. If you are using this in a very limited way, you can write: @MirrorsUsed(..., override: const ['reflection']) You can use the parameters of this annotation to say what you want to keep around at runtime. The "override" parameter tells dart2js to apply this to the import that comes from reflection.dart (which has that library name, see: https://github.com/mezoni/reflection/blob/master/lib/reflection.dart). I personally try to avoid using mirrors unless I know how to also generate code automatically that can replace the mirror calls. This is what we do today in polymer. We do this in our initialization code and how we read data from templates. For the latter, we use 'package:smoke', a package with 2 implementations: A mirror-based implementation which we use during development in Dartium, and a second implementation that can take generated code and use it to implement the same API. Hope this helps! |
|
This comment was originally written by [email protected] Thanks for the very helpful information! |
|
Removed Area-Polymer label. |
|
I'm closing this bug since all pending issues here are now tracked in issues 18490 and 18491. Added Done label. |
DartBot
added
Type-Defect
area-pkg
|
This issue has been moved to dart-archive/polymer-dart#171. |
This issue was originally filed by [email protected]
Dart2js output contains the following erorr messages:
This import is not annotated with @MirrorsUsed, which may lead to unnecessarily large generated code.
Try adding '@MirrorsUsed(...)' as described at https://goo.gl/Akrrog.
import 'dart:mirrors';
^^^^^^^^^^^^^^^^^^^^^^
[Info from Dart2JS]:
Took 0:00:18.394552 to compile od_web|web/load.html_bootstrap.dart.
[Info from Dart2JS]:
Compiling od_web|web/resetPassword.html_bootstrap.dart...
294 methods retained for use by dart:mirrors out of 2026 total methods (15%).
[Info from Dart2JS]:
Took 0:00:05.577569 to compile od_web|web/resetPassword.html_bootstrap.dart.
[Info from Dart2JS]:
Compiling od_web|web/profile.html_bootstrap.dart...
'smoke_8' has no member named 'T'.
#viewmodel: const Declaration(#viewmodel, smoke_8.T, kind: PROPERTY, annotations: const [smoke_2.reflectable, smoke_1.published]),
^^^^^^^^^
Not a compile-time constant.
#viewmodel: const Declaration(#viewmodel, smoke_8.T, kind: PROPERTY, annotations: const [smoke_2.reflectable, smoke_1.published]),
^^^^^^^^^
[Info from Dart2JS]:
Took 0:00:05.676572 to compile od_web|web/profile.html_bootstrap.dart.
Took 0:00:10.231995 to compile od_web|web/home.html_bootstrap.dart.
[Info from Dart2JS]:
Compiling od_web|web/data.html_bootstrap.dart...
'smoke_9' has no member named 'T'.
#viewmodel: const Declaration(#viewmodel, smoke_9.T, kind: PROPERTY, annotations: const [smoke_2.reflectable, smoke_1.published]),
^^^^^^^^^
Not a compile-time constant.
#viewmodel: const Declaration(#viewmodel, smoke_9.T, kind: PROPERTY, annotations: const [smoke_2.reflectable, smoke_1.published]),
^^^^^^^^^
[Info from Dart2JS]:
Took 0:00:09.715136 to compile od_web|web/data.html_bootstrap.dart.
[Info from Dart2JS]:
Compiling od_web|web/profilewizard.html_bootstrap.dart...
'smoke_15' has no member named 'T'.
#viewmodel: const Declaration(#viewmodel, smoke_15.T, kind: PROPERTY, annotations: const [smoke_2.reflectable, smoke_1.published]),
^^^^^^^^^^
'smoke_15' has no member named 'T'.
#viewmodel: const Declaration(#viewmodel, smoke_15.T, kind: PROPERTY, annotations: const [smoke_2.reflectable, smoke_1.published]),
^^^^^^^^^^
Not a compile-time constant.
#viewmodel: const Declaration(#viewmodel, smoke_15.T, kind: PROPERTY, annotations: const [smoke_2.reflectable, smoke_1.published]),
^^^^^^^^^^
[Info from Dart2JS]:
Took 0:00:22.513475 to compile od_web|web/profilewizard.html_bootstrap.dart.
[Info from Dart2JS]:
Compiling od_web|web/datawizard.html_bootstrap.dart...
Symbol literal '#_hightlightChanged' is currently unsupported by dart2js.
#_hightlightChanged: (o) => o._hightlightChanged,
^^^^^^^^^^^^^^^^^^^
'smoke_14' has no member named 'T'.
#viewmodel: const Declaration(#viewmodel, smoke_14.T, kind: PROPERTY, annotations: const [smoke_2.reflectable, smoke_1.published]),
^^^^^^^^^^
Symbol literal '#_hightlightChanged' is currently unsupported by dart2js.
#_hightlightChanged: const Declaration(#_hightlightChanged, Function, kind: METHOD),
^^^^^^^^^^^^^^^^^^^
Symbol literal '#_hightlightChanged' is currently unsupported by dart2js.
#_hightlightChanged: const Declaration(#_hightlightChanged, Function, kind: METHOD),
^^^^^^^^^^^^^^^^^^^
Symbol literal '#_hightlightChanged' is currently unsupported by dart2js.
#_hightlightChanged: r'_hightlightChanged',
^^^^^^^^^^^^^^^^^^^
Not a compile-time constant.
#viewmodel: const Declaration(#viewmodel, smoke_14.T, kind: PROPERTY, annotations: const [smoke_2.reflectable, smoke_1.published]),
^^^^^^^^^^
[Info from Dart2JS]:
Took 0:00:04.672336 to compile od_web|web/datawizard.html_bootstrap.dart.
Build failed.
What version of the product are you using? On what operating system?
The text was updated successfully, but these errors were encountered: