Skip to content

improve handling of private methods in polymer code generation #18490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sigmundch opened this issue Apr 28, 2014 · 15 comments
Closed

improve handling of private methods in polymer code generation #18490

sigmundch opened this issue Apr 28, 2014 · 15 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@sigmundch
Copy link
Member

See: https://code.google.com/p/dart/issues/detail?id=18481

Options:
(a) give better error messages in cases like _highlightChanged
(b) add support for private methods. This would require:
  - switching smoke to use strings instead of symbols (#_foo is not supported)
  - switching codegeneration to generate code on each library (requires issue #18489), we then can generate the getters for these private symbols in the context of the same library
@sigmundch
Copy link
Member Author

Marked this as blocking #18481.

@sigmundch
Copy link
Member Author

Issue #13881 has been merged into this issue.

cc @jmesserly.

@sigmundch
Copy link
Member Author

Removed Type-Defect label.
Added Type-Enhancement label.

@sigmundch
Copy link
Member Author

Added this to the Later milestone.

@jmesserly
Copy link

Added Pkg-Polymer label.

@jmesserly
Copy link

Removed Pkg-Polymer label.
Added Pkg-PolymerBuild label.

@jmesserly
Copy link

Removed Library-PolymerBuild label.

@jmesserly
Copy link

Removed Area-Polymer label.
Added Area-Pkg label.

@sigmundch
Copy link
Member Author

Removed Priority-Unassigned label.
Added Priority-Medium label.

@sigmundch
Copy link
Member Author

Removed Priority-Medium label.
Added Priority-Low label.

@sigmundch
Copy link
Member Author

Added Polymer-P-2 label.

@sigmundch
Copy link
Member Author

Removed this from the Later milestone.

@sigmundch
Copy link
Member Author

Removed Polymer-P-2 label.
Added Polymer-Milestone-Later label.

@sigmundch
Copy link
Member Author

Removed Polymer-Milestone-Later label.
Added PolymerMilestone-Later label.

@sigmundch sigmundch added Type-Enhancement area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P3 A lower priority bug or feature request labels Jul 9, 2014
@sigmundch sigmundch mentioned this issue Jun 5, 2015
Closed
This was referenced Jun 5, 2015
Closed
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/polymer-dart#390.

@DartBot DartBot closed this as completed Jun 5, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @jmesserly @sigmundch @DartBot