Skip to content

add support for global transformers in code_transformers #18489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sigmundch opened this issue Apr 28, 2014 · 18 comments
Closed

add support for global transformers in code_transformers #18489

sigmundch opened this issue Apr 28, 2014 · 18 comments
Assignees
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@sigmundch
Copy link
Member

Implement a generic transformer that:

  • can only run in the entrypoint package
  • allows specifying modifications to files in any package, but that are only visible to the compilation of a single entrypoint.
  • does a functional copy of the import graph, so that all these modifications are supported.
@sigmundch
Copy link
Member Author

Marked this as blocking #19168.

@sigmundch
Copy link
Member Author

Marked this as blocking #15080.

@sigmundch
Copy link
Member Author

Added this to the 1.6 milestone.
Removed Priority-Unassigned label.
Added Priority-High label.

@sigmundch
Copy link
Member Author

Removed this from the 1.6 milestone.
Added Polymer-P-1 label.

@sigmundch
Copy link
Member Author

Removed Polymer-P-1 label.
Added Polymer-Milestone-Next label.

@sigmundch
Copy link
Member Author

Added PolymerMilestone-Next label.

@sigmundch
Copy link
Member Author

Removed Polymer-Milestone-Next label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Added this to the 1.6 milestone.

@sigmundch
Copy link
Member Author

Removed this from the 1.6 milestone.

@sigmundch
Copy link
Member Author

Marked this as blocking #19521.

@sigmundch
Copy link
Member Author

Marked this as blocking #20267.

@kasperl
Copy link

kasperl commented Aug 6, 2014

Added this to the 1.6 milestone.

@sigmundch
Copy link
Member Author

Removed this from the 1.6 milestone.

@sigmundch
Copy link
Member Author

Marked this as blocking #20691.

@justinfagnani
Copy link
Contributor

+Bob and Natalie

Shouldn't this be a basic feature of pub and barback rather than be built as a separate transformer system on top of it?

I need a global transformer for js-interop, and we already have ones that workaround pub's single-package limitation for Polymer, Angular, and any transformer that uses code_transformers.


cc @nex3.
cc @munificent.

@justinfagnani
Copy link
Contributor

Siggi just pointed me to the bug on barkback. https://code.google.com/p/dart/issues/detail?id=17306

@kasperl
Copy link

kasperl commented Nov 28, 2014

Added Accepted label.

@sigmundch sigmundch added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Nov 28, 2014
@sigmundch sigmundch self-assigned this Nov 28, 2014
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/code_transformers#17.

@DartBot DartBot closed this as completed Jun 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

4 participants