Automatically reload transformers when the pubspec changes

[stevemessick]

[user feedback]

Adding transformers to a pubspec requires me to manually kill pub serve.

I added the polymer transformer, but was still getting errors in my app resulting from not having the transformer. Killing pub serve fixed the problem.
////////////////////////////////////////////////////////////////////////////////////
Editor: 1.5.0.dev_02_00 (2014-05-26)
OS: Mac OS X - x86_64 (10.9.2)
JVM: 1.6.0_65

projects: 26

open dart files: 8

auto-run pub: true
localhost resolves to: 127.0.0.1
mem max/total/free: 1983 / 1983 / 237 MB
thread count: 55
index: 5630817 relationships in 418107 keys in 4146 sources

SDK installed: true
Dartium installed: true

[nex3]

Please include the --verbose log of the errors you're receiving.

---

Added NeedsInfo label.

[justinfagnani]

This was reported by me via the Editor feedback. I just happened to see it roll by the issues list, but you should know there's no way for Steve to get you more info from [user feedback].

Anyway, I didn't receive any errors from pub, I received errors from Polymer because pub didn't run the transformer I added, it just happily used the stale configuration from the previous version of my pubspec.yaml.

---

Added Triaged label.

[nex3]

Removed Priority-Unassigned label.
Added Priority-Low label.
Changed the title to: "Automatically reload transformers when the pubspec changes".

[nex3]

Issue #19214 has been merged into this issue.

[nex3]

Marked this as blocking #14206.

[DartBot]

This comment was originally written by @zoechi

---

Currently pub serve kills itself when the pubspec.yaml of the project it currently serves was changes (I assume it is pub serve or is it DartEditor who kills pub serve?)

I had the case today where I had to add a transformer to a dependency (path dependency). In this case pub serve wasn't killed and it took me a while to figure out why the configuration change didn't take effect.

See also https://code.google.com/p/dart/issues/detail?id=20673

[munificent]

I assume it is pub serve or is it DartEditor who kills pub serve?

It's an Editor feature. Pub serve itself doesn't currently check for this (though we would like it to).

I had the case today where I had to add a transformer to a dependency (path dependency). In this case pub serve wasn't killed and it took me a while to figure out why the configuration change didn't take effect.

Ah, yes. I don't think the Editor considers that case.

---

Removed Area-Pub label.
Added Area-Editor label.

[sethladd]

Seems reasonable to restart pub serve when a change to pubspec.yaml is detected.

---

Set owner to @keertip.
Removed Priority-Low label.
Added Priority-Hg label.

[sethladd]

Added this to the 1.7 milestone.
Removed Priority-Hg label.
Added Priority-High label.

[munificent]

Seems reasonable to restart pub serve when a change to pubspec.yaml is detected.

My understanding is that the Editor does that now when it's your own pubspec that changed. What it doesn't do, that gzoechi is talking about, is monitor the pubspecs of your path dependencies for changes.

[sethladd]

ah, thanks for the clarification.

[sethladd]

Would it be reasonable for pub serve to reload itself when pubspec.yaml changes? This way, it's not an Editor responsibility and WebStorm, Sublime, and other plugins will get this for free.

Going to close this for Editor, but would love to see a discussion around reloading and pub serve.

---

Added NotPlanned label.