Skip to content

Invalidate & regenerate script snapshots for globally installed dart apps #21904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mkustermann opened this issue Dec 17, 2014 · 7 comments
Closed
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@mkustermann
Copy link
Member

Reproduction on my machine:

$ pub global activate -sgit https://github.com/dart-lang/dart_style
$ dartformat
Wrong script snapshot version, expected 'f6711525cff9f7d0d08595166664b767' found '74629058babcf012a75ec8e5b364e464'

Pub should make sure to invalidate script snapshots and re-generate them (on demand) when the dart binary changed.

@mkustermann
Copy link
Member Author

Added Area-Pub label.

@mkustermann
Copy link
Member Author

For completeness:

$ which dartformat
/usr/.../kustermann/.pub-cache/bin/dartformat
$ cat $(which dartformat)

#!/usr/bin/env sh

This file was created by pub v1.9.0-dev.0.0.

Package: dart_style

Version: 0.1.0-dev

Executable: dartformat

Script: format

dart "/usr/local/google/home/kustermann/.pub-cache/global_packages/dart_style/bin/format.dart.snapshot" "$@"

@munificent
Copy link
Member

Removed Priority-Unassigned label.
Added Priority-High label.

@nex3
Copy link
Member

nex3 commented Dec 17, 2014

Try upgrading pub to the latest bleeding edge and running "pub cache repair". This should have been fixed in r42055.

@mkustermann
Copy link
Member Author

It works, but the fact that it prints

"Wrong script snapshot version, expected 'f6711525cff9f7d0d08595166664b767' found 'a3a313ea90040f8a3aaa5f443ecbb3db'"

is not nice at all.

One way of avoiding this would be to add something like "dart --test-snapshot-compatibility file.snapshot", so one can ask the VM whether it can read the snapshot, instead of just trying to run it and see what happens :-/

If one would implement this, you could also use "exec dart ..." instead.

@nex3
Copy link
Member

nex3 commented Dec 18, 2014

I agree. I filed issue #20802 and issue #20784 when we first started supporting snapshots, but nothing has happened there.


Added Fixed label.

@mkustermann mkustermann added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures labels Dec 18, 2014
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#1217.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

4 participants