webkitRequestAnimationFrame throws exception in dartium (windows)

[DartBot]

This issue was originally filed by [email protected]

---

What steps will reproduce the problem?

I am doing this:

window.webkitRequestAnimationFrame((int ignoredCurrentTimeMs) { frame(); }, document);

This works for me when generating and running .js

What is the expected output? What do you see instead?

I updated to the new Dart Editor 6213 with Developer Build 130452 Windows embedded, and now when running my application I get this Exception:

Exception: Invalid class: expected instance of ElementImplementation
Stack Trace: 0. Function: 'DOMWindowImplementation._webkitRequestAnimationFrame@1c3f8015' url: 'e:\b\build\slave\dartium-win-full\build\src\build\Release\obj\global_intermediate\webkit\bindings\dart\dart\DOMWindowImplementation.dart' line:353 col:3
 1. Function: 'DOMWindowImplementation.webkitRequestAnimationFrame' url: 'e:\b\build\slave\dartium-win-full\build\src\build\Release\obj\global_intermediate\webkit\bindings\dart\dart\DOMWindowImplementation.dart' line:348 col:40
 2. Function: '[email protected]' url: 'dart:html' line:21228 col:50

What version of the product are you using? On what operating system?

Dart Editor 6213 with Developer Build 130452 Windows

If you are reporting a problem in the Dart Editor, please open the Help ->
About Dart Editor dialog and add the Dart SDK version number to this
report. If you prefer, you can use the 'Send Feedback' button in the Dart
Editor to file a report that will contain this information and additional
context helpful for debugging the problem.

Please provide any additional information below.

Please let me know if anyone has a workaround - right now this is kind of a show-stopper for me to use Dartium :(

[DartBot]

This comment was originally written by [email protected]

---

Set owner to [email protected].
Added Area-Dartium, Triaged labels.

[DartBot]

This comment was originally written by [email protected]

---

Ross, I am not sure it's a bug in Dartium.

According to IDL the 2nd argument should be an Element, and HTMLDocument is not an element.

In JS (at least for v8) it works by just ignoring your document passed.

I'd recommend you to pass document.body. If you like, we may make webkitRequestAnimationFrame accept null as a second argument (and make it a default value).

---

Added NeedsInfo label.

[DartBot]

This comment was originally written by [email protected]

---

Hi Anton,

The 2nd argument was actually removed from the spec:
http://www.w3.org/TR/animation-timing/

Also see Paul Irish's post:
http://paulirish.com/2011/requestanimationframe-for-smart-animating/

So I think that Dart(ium) should not be providing this argument in the dart:html API at all...

According to the API docs here, Document is an Element:
http://api.dartlang.org/html/Document.html

The following code prints 'its an Element!' both in .js and in dartium:
if(document is Element) print('its an Element!');

And I've actually copy/pasted that line of code from here:
https://code.google.com/p/dart/source/browse/trunk/dart/samples/ui_lib/base/AnimationScheduler.dart

My preference would be to remove this second parameter from the API ASAP since it is not spec'ed.

cheers
-Ross

[DartBot]

This comment was originally written by [email protected]

---

I think this issue is actually jacob's TODO in the catch:

try {
          // TODO(jacobr): passing in document should not be required.
          _intervalId = window.webkitRequestAnimationFrame(
              (int ignored) { _step(); }, document);
              // TODO(jacobr) fix this odd type error.
        } catch (var e) {
          _webkitAnimationFrameMaybeAvailable = false;
        }

[DartBot]

This comment was originally written by [email protected]

---

Ross,

for dart:dom we try to keep close to WebKit IDLs which has this second argument.

Let me reassign to dart:html folks.

Stephen, Vijay, any thooughts?

---

cc @rakudrama.
cc @vsmenon.
Removed the owner.
Removed Area-Dartium label.
Added Area-UI label.

[DartBot]

This comment was originally written by [email protected]

---

Just FYI, as per http://trac.webkit.org/changeset/113573 the 2nd argument has been removed.

[vsmenon]

I just rolled to new WebKit IDL yesterday. The second arg is now gone from all dart:html and dart:dom APIs.

[DartBot]

This comment was originally written by [email protected]

---

awesome, thanks guys!

-Ross

[vsmenon]

This should be fixed now. Please reopen if there are still issues.

---

Added Fixed label.