Skip to content

Finalization cycle in r6407? #2523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iposva-google opened this issue Apr 11, 2012 · 2 comments
Closed

Finalization cycle in r6407? #2523

iposva-google opened this issue Apr 11, 2012 · 2 comments
Assignees
@crelier
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P0 A serious issue requiring immediate resolution

Comments

@iposva-google
Copy link
Contributor

out/Debug_ia32/dart --ignore-unrecognized-flags --enable_asserts --enable_type_checks /Sources/dart-all/dart/tests/utils/src/DummyCompilerTest.dart

will crash with

/Sources/dart-all/dart/runtime/vm/object.cc:1498: error: expected: is_finalized()

When synched at r6407 with the following stack trace:

­0 0x98ade332 in __kill ()

­1 0x98add932 in kill$UNIX2003 ()

­2 0x93248c0c in abort ()

­3 0x00001e75 in dart::DynamicAssertionHelper::Fail (this=0xbfffede0, format=0x181588 "expected: %s") at /Sources/dart-all/dart/runtime/platform/assert.cc:41

­4 0x000f3db8 in dart::Class::IsSubtypeOf (this=0xc52568, type_arguments=@0xc52590, other=@0xc52588, other_type_arguments=@0xc52570, malformed_error=0xc52458) at /Sources/dart-all/dart/runtime/vm/object.cc:1498

­5 0x000f4974 in dart::AbstractType::IsSubtypeOf (this=0xc52518, other=@0xc52520, malformed_error=0xc52458) at /Sources/dart-all/dart/runtime/vm/object.cc:2166

­6 0x000f3b26 in dart::AbstractTypeArguments::IsWithinBoundsOf (this=0xc511d8, cls=@0xc510f8, bounds_instantiator=@0xc511d8, malformed_error=0xc52458) at /Sources/dart-all/dart/runtime/vm/object.cc:2922

­7 0x00086d27 in dart::ClassFinalizer::FinalizeType (cls=@0xbffff864, type=@0xc42978, finalization=dart::ClassFinalizer::kFinalize) at /Sources/dart-all/dart/runtime/vm/class_finalizer.cc:706

­8 0x00086ef7 in dart::ClassFinalizer::ResolveAndFinalizeMemberTypes (cls=@0xbffff864) at /Sources/dart-all/dart/runtime/vm/class_finalizer.cc:840

­9 0x00087e89 in dart::ClassFinalizer::FinalizeClass (cls=@0xbffff864, generating_snapshot=false) at /Sources/dart-all/dart/runtime/vm/class_finalizer.cc:1023

­10 0x000892bb in dart::ClassFinalizer::FinalizePendingClasses (generating_snapshot=false) at /Sources/dart-all/dart/runtime/vm/class_finalizer.cc:66

­11 0x0002acae in dart::ClassFinalizer::FinalizePendingClasses () at class_finalizer.h:79

­12 0x00009b2e in dart::CheckIsolateState (isolate=0x9f8000, generating_snapshot=false) at /Sources/dart-all/dart/runtime/vm/dart_api_impl.cc:64

­13 0x0000ed24 in Dart_InvokeStatic (library_in=0x9f9630, class_name_in=0x9f9638, function_name_in=0x9f9634, number_of_arguments=0, arguments=0x0) at /Sources/dart-all/dart/runtime/vm/dart_api_impl.cc:2382

­14 0x00006344 in main (argc=5, argv=0xbffffb08) at /Sources/dart-all/dart/runtime/bin/main.cc:592

Please reenable DummyCompilerTest.dart once fixed.
@iposva-google
Copy link
Contributor Author

Disabled failing test in https://chromiumcodereview.appspot.com/10058001/

@crelier
Copy link
Contributor

crelier commented Apr 12, 2012

Fixed at r6446.

Added Fixed label.

@iposva-google iposva-google added Type-Defect P0 A serious issue requiring immediate resolution area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Apr 12, 2012
dart-bot pushed a commit that referenced this issue Jul 20, 2020
@sigurdm
Bump pub
ad3be0a 
git log --oneline 85bdb898aeb2ac7cea76489ba0bf4e52ff7a79bf..master
04b054b6 Find sdk path with cli_util (#2567)
36c195b9 Only alert about new prereleases for prereleases (#2556)
00b36394 Stop using deprecated mapMap from pkg:collection (#2544)
477cbe72 Improved expectations in flutter_plugin_format validator test (#2532)
a8e2442b `pub run` Don't write about precompilation if no terminal is attached (#2531)
d83d36a4 Don't precompile dependencies of global activate from path (#2530)
870f395c Sanitize git cache folder names (#2522)
03b7f9a5 Avoid divisive terms (#2523)
b239ada4 Remove divisive term (#2517)

Change-Id: I55ea52a86121a382dca5c0f85addd4513ada50bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154940
Reviewed-by: Jonas Jensen <[email protected]>
Commit-Queue: Sigurd Meldgaard <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crelier crelier

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P0 A serious issue requiring immediate resolution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iposva-google @crelier