Skip to content

Dartium doesn't stop at a breakpoint unless the Chrome dev inspector is open #25369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nex3 opened this issue Jan 7, 2016 · 2 comments
Closed
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@nex3
Copy link
Member

nex3 commented Jan 7, 2016

If you set a breakpoint in a script running in Dartium or content_shell, the debugger won't actually pause at that breakpoint unless the Chrome dev inspector itself is open. This is true even if Observatory itself is open, so setting a breakpoint in Observatory and then continuing will run right through the breakpoint.

This is a particularly problem for users using content_shell with the test runner. The runner displays both the Observatory URL and the remote debugger URL, so users who only care about code and not HTML elements would naturally choose to just use Observatory on its own. It also makes testing debugging-related functionality very difficult, since we have to somehow open the dev inspector to make any breakpoints work.

@zoechi
Copy link
Contributor

zoechi commented Jan 7, 2016

Interesting, in WebStorm (and DartEditor) the connection to the debugger is (was) disconnected as soon as the devtools are opened.

nex3 added a commit to dart-lang/test that referenced this issue Jan 7, 2016
When the browser is paused at a breakpoint, the runner will now open a
command-line console with a "restart" command that will restart the
current test.

This currently has no tests, due to dart-lang/sdk#25369 and the lack of
a programmatic API for interacting with Observatory. I've tested it
reasonably thoroughly by hand, but it's more likely than the average
feature to have lurking bugs.

Closes #335

[email protected]

Review URL: https://codereview.chromium.org//1561073003 .
nex3 added a commit to dart-lang/test that referenced this issue Jan 8, 2016
When the browser is paused at a breakpoint, the runner will now open a
command-line console with a "restart" command that will restart the
current test.

This currently has no tests, due to dart-lang/sdk#25369 and the lack of
a programmatic API for interacting with Observatory. I've tested it
reasonably thoroughly by hand, but it's more likely than the average
feature to have lurking bugs.

Closes #335

[email protected]

Review URL: https://codereview.chromium.org//1561073003 .
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed Type-Defect labels Mar 1, 2016
@terrylucas
Copy link
Contributor

You could using the debugger statement to stop (that should work).

Please re-try with Dart 1.24.2 Stable (Dartium 50).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

4 participants