Skip to content

vm crashes (exit code 138) with complex generics when using parts #25389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Andersmholmgren opened this issue Jan 9, 2016 · 5 comments
Closed
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@Andersmholmgren
Copy link

Similar to #25122 but only seems to take effect when code uses part of syntax

The following works

main() {}

abstract class ComponentState<S extends ComponentState> {}

abstract class AbstractListEditorState<D,
    S extends AbstractListEditorState<D, S>> extends ComponentState<S> {}

class IssueListEditorState
    extends AbstractListEditorState<String, IssueListEditorState>
    implements ComponentState<IssueListEditorState> {}

abstract class AbstractListEditor<D, S extends AbstractListEditorState<D, S>> {}

If you take this code and break it up as follows

library arghh;

part 'generics_new_parts_part.dart';

main() {}

abstract class AbstractListEditor<D, S extends AbstractListEditorState<D, S>> {}

and

part of arghh;

abstract class ComponentState<S extends ComponentState> {}

abstract class AbstractListEditorState<D,
    S extends AbstractListEditorState<D, S>> extends ComponentState<S> {}

class IssueListEditorState
    extends AbstractListEditorState<String, IssueListEditorState>
    implements ComponentState<IssueListEditorState> {}

it now crashes with the exit code 138

This seems to be have been introduced in 1.14.0-dev.5.0 and is still broken in dev.6.0.
I don't have any trouble in dev.4.0.

@fsc8000 fsc8000 added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Jan 11, 2016
@fsc8000
Copy link
Contributor

fsc8000 commented Jan 11, 2016

Could it be related to the fix of #25122 ?

@Andersmholmgren
Copy link
Author

I assume that was not directed at me?

Either way it is hard to tell for me as this code would have failed due to #25122 anyway. i.e. I can't test it with an older vm as it would fail anyway

@crelier
Copy link
Contributor

crelier commented Jan 13, 2016

There is a cl out for review fixing this issue.
https://codereview.chromium.org/1580643004/

@crelier
Copy link
Contributor

crelier commented Jan 13, 2016

Fixed

@crelier crelier closed this as completed Jan 13, 2016
@Andersmholmgren
Copy link
Author

Cool. Thanks
On Thu, 14 Jan 2016 at 6:24 AM, Régis Crelier [email protected]
wrote:

Closed #25389 #25389.


Reply to this email directly or view it on GitHub
#25389 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

3 participants