suggest identifiers that are not yet imported

[danrubel]

[alexander-doroshko]

Will this suggestion have a SourceEdit for the IDE to insert import (or to modify show/hide list)?

[danrubel]

Yes.

[danrubel]

When implementing this, we should be sure not to suggest test classes when completing in lib directory.

[danrubel]

To correctly implement this we must only suggest unimported types appropriate for the file being edited. More specifically...

• when editing a file in the lib/ directory, we should only suggest types in the lib/ directory or in packages in the dependencies: section of the pubspec.yaml.
• when editing a file in the bin/, example/, or web/ directories, we should only suggest types in that directory or the lib/ directory or in packages in the dependencies: section of the pubspec.yaml.
• when editing other files, we can suggest types anywhere in the package or in either the dependencies: or dev_dependencies: sections of the pubspec.yaml.
• when suggesting types from other packages, do not suggest types only accessible from lib/src (internal by convention) similar to what was done for Quick Fix

The blocking issue is that currently, there is no way for the completion service to know which packages are listed in dependencies: or dev_dependencies: sections of the pubspec.yaml.

[davidmorgan]

Am I right in thinking that this issue covers auto-completing to methods of types I haven't imported yet?

i.e. if I type 'new Foo()..', and 'Foo' is not imported, it will still suggest completions that come from Foo?

This is something I miss from IntelliJ's Java behaviour -- it means you can write a whole line of code before going back to add the import.

Thanks!

[danrubel]

Yes. Implementing it correctly (see above) means some additional low level functionality in analyzer in addition to the code completion mods.

This is something I'd definitely like to see added, but have not had the cycles to get to it. There's a laundry list of things to do and I don't have a good feel for where this one fits in the priority list.

[davidmorgan]

Thanks. I will stay subscribed ;)