Skip to content

Changelog: void arrow functions should allow any rhs type #29646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eernstg opened this issue May 18, 2017 · 5 comments
Closed

Changelog: void arrow functions should allow any rhs type #29646

eernstg opened this issue May 18, 2017 · 5 comments
Assignees
@eernstg
Labels
area-documentation Prefer using 'type-documentation' and a specific area label.
Milestone
1.24

Comments

@eernstg
Copy link
Member

eernstg commented May 18, 2017

This is the changelog issue for #28939.
@eernstg eernstg self-assigned this May 18, 2017
@eernstg eernstg added the area-documentation Prefer using 'type-documentation' and a specific area label. label May 18, 2017
@eernstg eernstg added this to the 1.24 milestone May 18, 2017
@eernstg eernstg changed the title Changelog: void arrow functions should allow any rhs type #28940 Changelog: void arrow functions should allow any rhs type May 18, 2017
@floitschG floitschG mentioned this issue May 18, 2017
Closed
4 tasks
eernstg added a commit that referenced this issue May 18, 2017
@eernstg
Announced #28939 (void f() => e allows an e of any type) in changelog
9820535 
Addresses sdk issue #29646.

[email protected]

Review-Url: https://codereview.chromium.org/2887253003 .
@whesse
Copy link
Contributor

whesse commented May 22, 2017

Is this issue finished now? Can it be closed?

@eernstg
Copy link
Member Author

eernstg commented May 22, 2017 •
edited
Loading

Sorry, I forgot: it's landed as 9820535 on 2017-05-18. Closing.

@eernstg eernstg closed this as completed May 22, 2017
@zoechi
Copy link
Contributor

zoechi commented May 22, 2017

Does this mean that using => is now fine for setters?

@floitschG
Copy link
Contributor

Yes. It will be.
I believe we haven't yet changed the analyzer's check, though.

@eernstg
Copy link
Member Author

eernstg commented May 22, 2017 •
edited
Loading

The analyzer handles this from 6cb0966, 2017-05-11, and that seems to be included in 1.24.0-dev.5.0. There was one omission (setters), but that was in fact already covered by the implementation in the analyzer (and in dart2js), so the only thing we're doing for that is adding a few tests (so it shouldn't affect you that they haven't been landed yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eernstg eernstg

Labels
area-documentation Prefer using 'type-documentation' and a specific area label.
Projects
None yet
Milestone
1.24
Development

No branches or pull requests
4 participants
@zoechi @whesse @floitschG @eernstg