Skip to content

Library names on windows don't respect --library-root (missing subdirs) #29710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jakemac53 opened this issue May 24, 2017 · 1 comment
Closed

Library names on windows don't respect --library-root (missing subdirs) #29710

jakemac53 opened this issue May 24, 2017 · 1 comment
Assignees
@vsmenon
Labels
os-windows type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dev-compiler

Comments

@jakemac53
Copy link
Contributor

See dart-lang/pub#1622 for the original issue.

You can repro by downloading the attached project, and the running:

dartdevc -o web\module.js --library-root web --module-root web web\subdir\main.dart

If you look at the compiled module on windows the library name for web\subdir\main.dart is just main, and on linux/mac it is subdir__main which is what I would expect given the library root is web.
@jakemac53 jakemac53 added web-dev-compiler os-windows type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels May 24, 2017
@jakemac53
Copy link
Contributor Author

Fixed by https://codereview.chromium.org/2899363002/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

Labels
os-windows type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dev-compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakemac53 @vsmenon