Skip to content

Pub serve in DDC mode doesn't work for project from web/subdir #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devoncarew opened this issue May 24, 2017 · 7 comments
Closed

Pub serve in DDC mode doesn't work for project from web/subdir #1622

devoncarew opened this issue May 24, 2017 · 7 comments

Comments

@devoncarew
Copy link
Member

From @alexander-doroshko on May 24, 2017 13:12

Environment: Windows 10, Dart SDK 1.24.0-dev.5.0.
Steps:

  • Unzip the attached project, run pub get.
  • Run pub serve from the command line.
  • Open http://localhost:8080/subdir/index.html in Chrome. The app works just fine.
  • Restart pub in DDC mode: pub serve --compiler=dartdevc.
  • Open http://localhost:8080/subdir/index.html in Chrome. The app doesn't load.

Copied from original issue: dart-lang/sdk#29704

@devoncarew
Copy link
Member Author

/cc @jakemac53

@jakemac53
Copy link
Contributor

This has been fixed already actually, the 1.24.0-dev.6.0 release should work (I also tested this project with my locally built sdk and it works).

@alexander-doroshko
Copy link

FWIW the problem is still reproduced with

dartsdk-windows-x64-release.zip	24-May-2017 13:42	58.7M	"a5033a1906eb6a6b9113995ec6c449ff"

from http://gsdview.appspot.com/dart-archive/channels/dev/raw/1.24.0-dev.6.0/sdk/

@jakemac53 jakemac53 reopened this May 24, 2017
@jakemac53
Copy link
Contributor

It is probably a windows specific issue, investigating further

@jakemac53
Copy link
Contributor

Alright, confirmed this is reproducible on windows. It looks like the library name for the module is missing the subdirectory portion on windows, so we try to call main() on a non-existing library.

@jakemac53
Copy link
Contributor

Fwiw, resolving dart-lang/sdk#27262 would likely solve this issue.

@jakemac53
Copy link
Contributor

Fixed by https://codereview.chromium.org/2899363002/, working on a cherry pick now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants