Skip to content

Please merge revision 5919a12038920d5084116bd101e8013b789765bb into dev channel #29724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakemac53 opened this issue May 25, 2017 · 10 comments
Closed

Comments

@jakemac53
Copy link
Contributor

@whesse @mit-mit @kasperl

This fixes serving apps from a subdirectory of web on windows, with ddc (see dart-lang/pub#1622).

5919a12

This merged cleanly

@jakemac53
Copy link
Contributor Author

jakemac53 commented May 25, 2017

Note that I will have a few more coming as well, if you want to wait and do them all at once.

@dgrove
Copy link
Contributor

dgrove commented May 25, 2017

Any more? I'll be doing this integration pretty soon.

@jakemac53
Copy link
Contributor Author

There are two more coming, but one is still out for review and the other is blocked on it (but has lgtm).

@dgrove
Copy link
Contributor

dgrove commented May 26, 2017 via email

@jakemac53
Copy link
Contributor Author

Sgtm, thanks!

@jakemac53
Copy link
Contributor Author

97b7504 is also ready now

@dgrove
Copy link
Contributor

dgrove commented May 26, 2017

5919a12 no longer merges cleanly against dev.

@jakemac53
Copy link
Contributor Author

Closing as we talked offline, looks like dev got moved up to a more recent version somehow....

@dgrove
Copy link
Contributor

dgrove commented May 26, 2017

It turns out that 5919a12 was already picked in 83c8cbd .

@dgrove
Copy link
Contributor

dgrove commented May 26, 2017

97b7504 was merged in f5af386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants