Skip to content

support hot reload from a partial kernel file #30109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sigmundch opened this issue Jul 7, 2017 · 2 comments
Closed

support hot reload from a partial kernel file #30109

sigmundch opened this issue Jul 7, 2017 · 2 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. vm-hot-reload

Comments

@sigmundch
Copy link
Member

(I couldn't find whether we have filed an issue for this already)

Hot reload from kernel works when the incremental kernel generator sends down the entire program after a reload. However, if we send a partial program, the VM crashes.

To reproduce:

./out/ReleaseX64/dart pkg/front_end/test/src/incremental/hot_reload_e2e_test.dart

you should see the failure on the unit test titled "reload after non-leaf library modification".

You can also run this test via test.py, but you need to remove the Skip entry in the pkg.status file at this time. The test is being skipped because it appears to show other flaky issues as well (see #29819)

@sigmundch sigmundch added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. vm-hot-reload labels Jul 7, 2017
@sigmundch
Copy link
Member Author

Note: because the test is being skipped, I noticed that the test broke when we removed the --platform flag. This CL https://codereview.chromium.org/2976553002/ should fix that.

@sigmundch
Copy link
Member Author

Note: the CL landed, so the test is now updated and operational in master (but still marked as Skip in the status file)

a-siva added a commit that referenced this issue Aug 18, 2017
…uring

   reload instead of computing it based on the source modification information.

2. Fix for failure in Unit test case #30322

3. Fix crash in test that was being skipped in #30109 and turn that test on.

This CL is work towards completing issue #28051

[email protected]

Review-Url: https://codereview.chromium.org/2998983002 .
@a-siva a-siva closed this as completed Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. vm-hot-reload
Projects
None yet
Development

No branches or pull requests

2 participants