-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Dart Editor refreshes .git folder #3044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Brian: does your DartProjectImpl fix address this issue (with or without Dan's analysis server resource change listener refinement)? Or are there other bits to consider? Set owner to @bwilkerson. |
I don't know. I didn't try to reproduce the problem. It's quite possible that the refresh mechanism is inherited from Eclipse and is totally unaffected by either change. Removed the owner. |
We made some changes to stop scanning "dot" folders... Please reopen if you are still seeing this problem in a clean workpsace, and we will dig further. Added Fixed label. |
New commits include: ``` git log --format="%C(auto) %h %s" d159e5b9f04a7e4826b6afea7b3364d48aa0dad8..70b1a4f9229a36bac6340ec7eae2b2068baac96c 70b1a4f9 Detect Flutter SDK location relative to Dart SDK (#3045) b4be5c57 Dart format with latest SDK (#3044) 2a08832e Fix dart_tools typos (#3042) ``` Change-Id: I5d27c9545f5e13a55cf1719fe1408a88fba88c8d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207304 Auto-Submit: Jonas Jensen <[email protected]> Commit-Queue: William Hesse <[email protected]> Reviewed-by: William Hesse <[email protected]>
…2 revisions) https://dart.googlesource.com/dartdoc/+log/cf0685a2d1ce..c58f21042ebd 2022-05-21 [email protected] Fix two issues with constructors (#3044) 2022-05-21 [email protected] inline the used charcode constants (#3045) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-doc-dart-sdk Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: Ic1521181d7c2784b52018d7233ac0a937d0e979c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245640 Reviewed-by: Nate Bosch <[email protected]> Commit-Queue: Nate Bosch <[email protected]>
This issue was originally filed by @ltackmann
What steps will reproduce the problem?
What is the expected output? What do you see instead?
.git folders (and likely all other . folders) should be completely ignored when refreshing. In particular hidden source control folders can contain fragments of Dart code that should not be refreshed.
What version of the product are you using? On what operating system?
Dart editor 7566 on Mac OS X 1.7.3
Please provide any additional information below.
The text was updated successfully, but these errors were encountered: