Skip to content

[VM] make --strong without --dfe an error #31561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chalin opened this issue Dec 6, 2017 · 2 comments
Closed

[VM] make --strong without --dfe an error #31561

chalin opened this issue Dec 6, 2017 · 2 comments
Assignees
@sivachandra
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@chalin
Copy link
Contributor

chalin commented Dec 6, 2017

Followup to @mraleph's comment in #31534 (comment)

Could you also make --dfe report an error until it is actually implemented?

cc @kwalrath @kevmoo
@chalin chalin mentioned this issue Dec 6, 2017
Closed
@floitschG floitschG added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Dec 22, 2017
@a-siva
Copy link
Contributor

a-siva commented Jan 3, 2018 •
edited
Loading

@sivachandra is working on cleaning up some of the options that the VM uses when running in 2.0 mode.
The goal is to have a single '--preview-dart-2' option that turns on Dart 2.0 which would be strong mode
by default.
This will be addressed by that change.

@a-siva a-siva mentioned this issue Jan 9, 2018
Closed
@a-siva
Copy link
Contributor

a-siva commented Feb 7, 2018

We are making --strong the default for --preview_dart_2 and the --dfe option is not a requirement for running dart with the new front end. This bug is obsolete with the new --preview_dart_2 option.

@a-siva a-siva closed this as completed Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sivachandra sivachandra

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sivachandra @chalin @floitschG @a-siva