Skip to content

Add full support for dart 2.0 mode in command line Dart and SDK #31807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
a-siva opened this issue Jan 9, 2018 · 9 comments
Closed

Add full support for dart 2.0 mode in command line Dart and SDK #31807

a-siva opened this issue Jan 9, 2018 · 9 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@a-siva
Copy link
Contributor

a-siva commented Jan 9, 2018

This is a meta bug to track support for dart 2.0 mode in command line Dart and SDK.
The idea is we need to get to a point where one could say
dart --preview-dart-2 hello.dart
and it works.

@a-siva a-siva added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Jan 9, 2018
@a-siva a-siva self-assigned this Jan 9, 2018
@a-siva
Copy link
Contributor Author

a-siva commented Jan 9, 2018

Related bugs that should be addressed for this support to be complete

Other FE issues that need to be fixed to get to being fully functional

Steps for later once the kernel format has stabilized

@devoncarew
Copy link
Member

For my own edification, the current way to run the VM with the CFE is using the script pkg/vm/tool/dart2.

@a-siva a-siva added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Jan 9, 2018
@zoechi
Copy link
Contributor

zoechi commented Jan 10, 2018

Will Dart2 run Dart1 programs or
will there be a way to have Dart1 and Dart2 installed at the same time?

@dgrove
Copy link
Contributor

dgrove commented Jan 11, 2018

The SDK is gradually moving to running Dart 2 only. As the SDK gets to Dart 2 only, you'd need a separate SDK installed to run Dart 1.

@zoechi
Copy link
Contributor

zoechi commented Jan 11, 2018

Don't you think this will cause issues if people use Dart apps that are not yet ported?
There can't be 2 dart.exe in the path at the same time.
Sorry for the noise in this thread, is it worth creating a new issue for that?

@dgrove
Copy link
Contributor

dgrove commented Jan 11, 2018 via email

@devoncarew
Copy link
Member

@a-siva, it looks like dart --preview-dart-2 hello.dart is working now; is that correct?

@a-siva
Copy link
Contributor Author

a-siva commented Feb 22, 2018

Not yet, we are still one CL away from it, --strong and --reify-generic-methods is not on when --preview-dart-2 is specified.

@a-siva
Copy link
Contributor Author

a-siva commented Dec 10, 2018

This is done.

@a-siva a-siva closed this as completed Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

4 participants