Skip to content

add support for dart-ext uri's #31618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
keertip opened this issue Dec 12, 2017 · 4 comments
Closed

add support for dart-ext uri's #31618

keertip opened this issue Dec 12, 2017 · 4 comments
Assignees
Labels
customer-bazel customer-vm legacy-area-front-end Legacy: Use area-dart-model instead. P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@keertip
Copy link
Contributor

keertip commented Dec 12, 2017

The front end's PhysicalFileSystem does not have support for dart-ext uri's, should support it.

@keertip
Copy link
Contributor Author

keertip commented Dec 12, 2017

cc @sigmundch

@sigmundch
Copy link
Member

Unlike #31594 - I believe this may require some additional work to properly support native extensions in the VM.

@keertip
Copy link
Contributor Author

keertip commented Dec 12, 2017

cc @a-siva

@keertip keertip added this to the 2.0-alpha milestone Dec 12, 2017
@keertip keertip added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Dec 14, 2017
@sigmundch
Copy link
Member

Just to share my thoughts about this bug:

  • changes in the FE are small: we need to add a file-system that accepts this scheme and simply returns an empty file. We might want to compose this together with the solution we do for add support for data:* URIs #31594.
  • the FE needs to annotate the libraries where these imports occur (or preserve the imports in the LIbraryDependencies so they are available to the VM when they load the kernel program)
  • during deserialization the VM needs to retrieve this information and properly load the native extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-bazel customer-vm legacy-area-front-end Legacy: Use area-dart-model instead. P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

4 participants