Skip to content

Kernel reader doesn't correctly mangle qualified symbol literals #33345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rmacnak-google opened this issue Jun 5, 2018 · 1 comment
Open

Kernel reader doesn't correctly mangle qualified symbol literals #33345

rmacnak-google opened this issue Jun 5, 2018 · 1 comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@rmacnak-google
Copy link
Contributor

Which causes at least mirrors/constructor_private_name_test to fail.
@rmacnak-google rmacnak-google added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Jun 5, 2018
@rmacnak-google
Copy link
Contributor Author

And even ignoring mirrors, causes incorrect equality results for symbols like #_private.public.

dart-bot pushed a commit that referenced this issue Jun 5, 2018
@rmacnak-google
[vm] Fix some missing private name mangling in the kernel reader.
787a43e 
Bug: #32345
Bug: #33326
Bug: #33345
Change-Id: I89fb8f0332ef6f9f40de59c219af2a7c23e5943f
Reviewed-on: https://dart-review.googlesource.com/58400
Commit-Queue: Ryan Macnak <[email protected]>
Reviewed-by: Vyacheslav Egorov <[email protected]>
Reviewed-by: Alexander Markov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmacnak-google