Skip to content

pub global activate packages don't work with --preview-dart-2 #33460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alorenzen opened this issue Jun 14, 2018 · 2 comments
Closed

pub global activate packages don't work with --preview-dart-2 #33460

alorenzen opened this issue Jun 14, 2018 · 2 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. customer-dart-2
Milestone

Comments

@alorenzen
Copy link
Contributor

Related to #32188
If I run
DART_VM_OPTIONS=--preview-dart-2 pub global run webdev build, then the dart2 flag is passed properly, and I can use dart2 features like optional new/const.

However, if I run

pub global activate webdev
DART_VM_OPTIONS=--preview-dart-2 webdev build

then the flag is not passed properly to the dart vm, so we get failures with optional new/const.

@alorenzen alorenzen added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. customer-dart-2 labels Jun 14, 2018
@JekCharlsonYu JekCharlsonYu added this to the Dart2Stable milestone Jun 14, 2018
@dgrove
Copy link
Contributor

dgrove commented Jun 14, 2018

This will be fixed automatically when the default is flipped to Dart 2 (which is happening very soon). Do es any work need to done here?

@dgrove
Copy link
Contributor

dgrove commented Jun 15, 2018

After talking with @natebosch , closing this, as it will be fixed automatically when Dart2Stable ships.

@dgrove dgrove closed this as completed Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. customer-dart-2
Projects
None yet
Development

No branches or pull requests

3 participants