Cannot use `pub` with --preview-dart-2 #32188

kevmoo · 2018-02-15T22:01:52Z

> DART_VM_OPTIONS=--preview-dart-2 pub 
Invalid isolate state - Unable to make it runnable

On Dart VM version: 2.0.0-dev.26.0 (Thu Feb 15 03:06:13 2018 +0100) on "macos_x64"

The text was updated successfully, but these errors were encountered:

kevmoo · 2018-02-15T22:02:03Z

CC @a-siva @nex3 @zanderso

a-siva · 2018-02-20T06:31:10Z

in the dart sdk builds pub, analyzer, dart2js and ddc use an application snapshot to run, these snapshots are built in dart 1 mode. When preview-dart-2 is specified it is not compatible with these snapshots and hence the failure. The error message is not very helpful and we will fix that.

To get these command with --preview-dart-2 first the pub, dart2js, analyzer code needs to be made strong mode clean and these application snapshots need to be generated with that option turned on. I think we planned to do this in Q2.

The issue that the original bug wanted addressed was a way for folks to run tests in preview-dart-2 mode using pub. For this to work 'pub run' needs to implement the --preview-dart-2 option so that it starts the test process using this option, somewhat similar to the '-c' or '--checked' option that it currently supports.

sivalinuxmach[sdk]>out/ReleaseX64/dart-sdk/bin/pub run --help
Run an executable from a package.

Usage: pub run [args...]
-h, --help Print this usage information.
-c, --[no-]checked Enable runtime type checks and assertions.
--mode Mode to run transformers in.
(defaults to "release" for dependencies, "debug" for entrypoint)

a-siva · 2018-02-20T19:20:18Z

Who needs to own this issue of implementing the option '--preview-dart-2' in 'pub run' ?
Not sure who owns pub these days.

kevmoo · 2018-02-20T19:44:18Z

@nex3 still does most of the work, although it's migrating slowly to AAR w/ @mit-mit driving

mit-mit · 2018-02-20T20:00:38Z

We have no plans, or bandwidth, to work on pub client in q1.

dgrove · 2018-04-17T02:52:34Z

@nex3 @grouma @natebosch Can you all figure out what's needed here?

dgrove · 2018-04-17T04:42:53Z

/cc @kmillikin - there are likely changes need to CFE to make it run on Dart 2.

jmesserly · 2018-04-17T19:17:31Z

/cc @kmillikin - there are likely changes need to CFE to make it run on Dart 2.

FYI, I was able to locally run DDC and DDK with --preview-dart-2. All tests were passing. Also DDC/DDK are now building themselves as part of their snapshot process (selfhost for training data), and that compile succeeds with no errors. Based on that I believe Analyzer/CFE are pretty Dart 2 clean at this point. (There might be some runtime cast failures on code paths that DDC/DDK does not exercise).

To get these command with --preview-dart-2 first the pub, dart2js, analyzer code needs to be made strong mode clean and these application snapshots need to be generated with that option turned on. I think we planned to do this in Q2.

I haven't figured out how to build the DDC snapshots yet with --preview-dart-2. Would appreciate help with that. I've been chatting a bit with @a-siva

nex3 · 2018-04-17T20:36:14Z

Once dart-lang/pub#1871 lands, we won't need dart2js or DDC to be Dart 2-compatible anymore. We do still use the analyzer, though—is that Dart 2-clean?

bwilkerson · 2018-04-17T20:44:22Z

There is at least one (external) method in dart:io that isn't, but all of the tests that don't rely on IO (which is the vast majority of them) pass. So, as far as I can tell based on our tests, yes, analyzer is Dart 2 clean. I'm sure we'll find a few bugs in code that isn't covered by tests.

natebosch · 2018-04-17T20:45:37Z

I'll work on checking that pub run code paths work in Dart 2 runtime.

I'll likely need some help getting it set up in the pub wrapping script in the SDK.

nex3 · 2018-04-17T20:49:26Z

Is test Dart 2 clean? If so, we should be able to verify pub's cleanliness by running its tests.

If not, we can get part of the way by spawning the pub subprocesses the tests run with --preview-dart-2.

natebosch · 2018-04-17T22:43:15Z

pub run seems to work when I fix the static errors.
dart-lang/pub#1874

However it's drastically slower.

Set up a package which has a single dependency:

dependencies:
  pub:
    path: ../pub

Invoke pub with no arguments - just prints usage and exits.

pub run pub - 1.36 s
dart ../pub/bin/pub.dart - 0.87s
dart ../pub/bin/pub.dart run pub - 1.76s
dart --preview-dart-2 ../pub/bin/pub.dart - 11.46s
dart --preview-dart-2 ../pub/bin/pub.dart run pub - 18.35s

It's possible that using a snapshot in Dart 2 semantics will be an improvement, and that this will carry over when using a hosted dependency rather than a path dependency...

natebosch · 2018-04-17T23:03:52Z

I can't get timing data with snapshots - #32911

natebosch · 2018-04-18T20:57:11Z

Here is the list of work that I think is blocking the end to end pub run --preview-dart-2 test scenario.

Sync pub into the SDK. Blocked on Move from pub build to dart2js for Observatory #32900
Set up the flags in the shell and bat script to get the --preview-dart-2 flag passed to the dart vm and not pub itself. (could skip this if we're ok with DART_VM_OPTIONS=--preview-dart-2 ux)
Ensure that package:test is Dart 2 runtime clean
Give pub an understanding of whether the run command is Dart 2 or not. Today it wants to run from snapshots when it can, and Dart1/Dart2 snapshots are incompatible (and today not possible for Dart2, blocked on Cannot run a snapshot with --preview-dart-2 #32911). The hacky thing to do is generate only 1 snapshot and run from source when using the "other" mode, the full solution would involve generating2 snapshots and picking the right one at runtime.

nex3 · 2018-04-18T21:01:27Z

Given that the running from source is so slow with the CFE right now, how do we verify that a given chunk of code is in fact Dart 2-clean?

vsmenon · 2018-04-18T21:02:06Z

@a-siva - note Nate's Dart 1 vs Dart 2 perf comment above.

mit-mit · 2018-04-20T10:30:03Z

This continues to cause friction when we work on making packages dart2 compatible. @a-siva is someone looking into the perf issues?

kevmoo · 2018-05-14T22:08:16Z

Pending CL - https://dart-review.googlesource.com/c/sdk/+/54743

vsmenon · 2018-05-15T19:01:56Z

@a-siva - @natebosch 's cl is breaking on the bots with:

C:/b/s/w/ir/cache/vpython/1bda7b/Scripts/python.exe ../../build/gn_run_binary.py compiled_action dart.exe --deterministic --packages=C:/b/s/w/ir/cache/builder/sdk/.packages --snapshot=gen/pub2.dart.snapshot --snapshot-depfile=C:/b/s/w/ir/cache/builder/sdk/out/ReleaseIA32/gen/pub2.dart.snapshot.d --preview-dart-2 --snapshot-kind=script C:/b/s/w/ir/cache/builder/sdk/third_party/pkg/pub/bin/pub.dart
Command failed: ./dart.exe --deterministic --packages=C:/b/s/w/ir/cache/builder/sdk/.packages --snapshot=gen/pub2.dart.snapshot --snapshot-depfile=C:/b/s/w/ir/cache/builder/sdk/out/ReleaseIA32/gen/pub2.dart.snapshot.d --preview-dart-2 --snapshot-kind=script C:/b/s/w/ir/cache/builder/sdk/third_party/pkg/pub/bin/pub.dart
output: c:/b/s/w/ir/cache/builder/sdk/.packages: Error: Unable to read '.packages' file:
  FileSystemException(uri=c:/b/s/w/ir/cache/builder/sdk/.packages; message=File c:/b/s/w/ir/cache/builder/sdk/.packages does not exist.).

I'm seeing similar with my DDC CL:

Command failed: ./dart --deterministic --packages=/Users/vsm/dart/sdk/.packages --snapshot=gen/dartdevc.dart.snapshot --snapshot-depfile=/Users/vsm/dart/sdk/xcodebuild/ReleaseX64/gen/dartdevc.dart.snapshot.d --preview-dart-2 --snapshot-kind=app-jit /Users/vsm/dart/sdk/pkg/dev_compiler/bin/dartdevc.dart --dart-sdk /Users/vsm/dart/sdk/sdk --dart-sdk-summary /Users/vsm/dart/sdk/xcodebuild/ReleaseX64/gen/utils/dartdevc/ddc_sdk.sum --library-root /Users/vsm/dart/sdk/pkg/dev_compiler -o dartdevc.js /Users/vsm/dart/sdk/pkg/dev_compiler/bin/dartdevc.dart
output: Error while initializing Kernel isolate

Any ideas?

keertip · 2018-05-15T19:30:30Z

@vsmenon, are you running from xcodebuild/ReleaseX64/ directory?

vsmenon · 2018-05-15T19:32:26Z

Yes.

vsmenon · 2018-05-16T17:57:08Z

@a-siva - I think we're blocked on this (and similar with DDC). It appears to be somewhat non-deterministic. Occasionally, DDC will build. Occasionally, it will fail with the "Kernel isolate" error. Occasionally (maybe just on bots), it will fail with the ".packages" error. Nate is seeing the same (we think) with pub.

a-siva · 2018-05-17T01:53:50Z

This CL https://dart-review.googlesource.com/c/sdk/+/55589 fixes the .package not found error but now an assertion in the optimizing compiler is being triggered which I am investigating.

alorenzen · 2018-05-17T21:42:41Z

Spoke to @JekCharlsonYu, this was moved to Stable by mistake.

a-siva · 2018-05-17T23:16:41Z

https://dart-review.googlesource.com/c/sdk/+/55589 is being reviewed

kevmoo · 2018-05-18T18:25:15Z

Fixed in 02e47a9

kevmoo · 2018-05-18T18:44:53Z

Spoke too soon. Waiting on https://dart-review.googlesource.com/c/sdk/+/54743 from @natebosch

natebosch · 2018-05-18T19:45:22Z

@a-siva I'm still unable to build locally.

Error while initializing Kernel isolate

Were you able to reproduce this error, did your CL fix it for you?

natebosch · 2018-05-18T20:27:55Z

the build error I'm seeing now might be flaky - it was for @vsmenon as well. I was able to get a successful build locally.

- Make a snapshot in Dart 2 mode - Check for the VM argument `--preview-dart-2` and run the correct snapshot Towards fixing #32188 Change-Id: I56d5e7f268ff40b80783fae571981705536280f2 Reviewed-on: https://dart-review.googlesource.com/54743 Commit-Queue: Nate Bosch <[email protected]> Reviewed-by: Keerti Parthasarathy <[email protected]> Reviewed-by: Kevin Moore <[email protected]>

kevmoo · 2018-05-18T20:34:09Z

Hopefully fixed in 2ff2af7

natebosch · 2018-05-18T20:39:07Z

We want dart-lang/pub#1683 to fix the performance issues, but we're unblocked to run things (from source) now.

kevmoo added customer-dart-2 area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Feb 15, 2018

kevmoo mentioned this issue Feb 20, 2018

Implement --preview-dart-2 option for pub run #32214

Closed

This was referenced Feb 20, 2018

Implement --preview-dart-2 option for pub run dart-lang/pub#1807

Closed

Add the ability to spawn an isolate in Dart 2 preview mode #32253

Closed

dgrove assigned natebosch, grouma and nex3 Apr 17, 2018

dgrove added this to the Dart2Beta4 milestone Apr 17, 2018

JekCharlsonYu added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Apr 17, 2018

vsmenon mentioned this issue Apr 19, 2018

Cannot run a snapshot with --preview-dart-2 #32911

Closed

vsmenon unassigned grouma Apr 20, 2018

This was referenced May 14, 2018

Add support for preview-dart-2 dart-lang/webdev#54

Closed

Release angular-5 beta angulardart/angular#1315

Closed

vsmenon assigned a-siva and unassigned natebosch May 16, 2018

JekCharlsonYu added the moved-from-dart2beta4 label May 17, 2018

JekCharlsonYu modified the milestones: Dart2Beta4, Dart2Stable May 17, 2018

alorenzen modified the milestones: Dart2Stable, Dart2Beta4 May 17, 2018

kevmoo closed this as completed May 18, 2018

kevmoo reopened this May 18, 2018

kevmoo assigned natebosch and unassigned a-siva May 18, 2018

kevmoo closed this as completed May 18, 2018

alorenzen mentioned this issue Jun 14, 2018

pub global activate packages don't work with --preview-dart-2 #33460

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cannot use `pub` with --preview-dart-2 #32188

Cannot use `pub` with --preview-dart-2 #32188

kevmoo commented Feb 15, 2018

kevmoo commented Feb 15, 2018

a-siva commented Feb 20, 2018

a-siva commented Feb 20, 2018

kevmoo commented Feb 20, 2018

mit-mit commented Feb 20, 2018

dgrove commented Apr 17, 2018

dgrove commented Apr 17, 2018

jmesserly commented Apr 17, 2018

nex3 commented Apr 17, 2018

bwilkerson commented Apr 17, 2018

natebosch commented Apr 17, 2018

nex3 commented Apr 17, 2018

natebosch commented Apr 17, 2018 •

edited

Loading

natebosch commented Apr 17, 2018

natebosch commented Apr 18, 2018 •

edited

Loading

nex3 commented Apr 18, 2018

vsmenon commented Apr 18, 2018

mit-mit commented Apr 20, 2018

kevmoo commented May 14, 2018

vsmenon commented May 15, 2018

keertip commented May 15, 2018

vsmenon commented May 15, 2018

vsmenon commented May 16, 2018

a-siva commented May 17, 2018

alorenzen commented May 17, 2018

a-siva commented May 17, 2018

kevmoo commented May 18, 2018

kevmoo commented May 18, 2018

natebosch commented May 18, 2018

natebosch commented May 18, 2018

kevmoo commented May 18, 2018

natebosch commented May 18, 2018

Cannot use pub with --preview-dart-2 #32188

Cannot use pub with --preview-dart-2 #32188

Comments

kevmoo commented Feb 15, 2018

kevmoo commented Feb 15, 2018

a-siva commented Feb 20, 2018

a-siva commented Feb 20, 2018

kevmoo commented Feb 20, 2018

mit-mit commented Feb 20, 2018

dgrove commented Apr 17, 2018

dgrove commented Apr 17, 2018

jmesserly commented Apr 17, 2018

nex3 commented Apr 17, 2018

bwilkerson commented Apr 17, 2018

natebosch commented Apr 17, 2018

nex3 commented Apr 17, 2018

natebosch commented Apr 17, 2018 • edited Loading

natebosch commented Apr 17, 2018

natebosch commented Apr 18, 2018 • edited Loading

nex3 commented Apr 18, 2018

vsmenon commented Apr 18, 2018

mit-mit commented Apr 20, 2018

kevmoo commented May 14, 2018

vsmenon commented May 15, 2018

keertip commented May 15, 2018

vsmenon commented May 15, 2018

vsmenon commented May 16, 2018

a-siva commented May 17, 2018

alorenzen commented May 17, 2018

a-siva commented May 17, 2018

kevmoo commented May 18, 2018

kevmoo commented May 18, 2018

natebosch commented May 18, 2018

natebosch commented May 18, 2018

kevmoo commented May 18, 2018

natebosch commented May 18, 2018

Cannot use `pub` with --preview-dart-2 #32188

Cannot use `pub` with --preview-dart-2 #32188

natebosch commented Apr 17, 2018 •

edited

Loading

natebosch commented Apr 18, 2018 •

edited

Loading