goal: switch analyzer to use --use-fasta-parser by default

[devoncarew]

[devoncarew]

CL in progress here: https://dart-review.googlesource.com/c/sdk/+/67090

[devoncarew]

@danrubel, it looks like we're not able to build the SDK with this flag on by default (I assume mostly the change to the AnalysisOptions.useFastaParser flag default).

https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8939840433045031248/+/steps/build_dart/0/stdout

The build is failing when DDC tries to build the summary of the Dart SDK libraries. It doesn't proceed if it finds any compilation errors (warnings are OK). W/ this flag flip, we're now reporting lots of errors in places we hadn't before. I assume these were things that are special cased by the analyzer's parser? This must be handled by DDC already in some fashion, in order to build DDK.

[devoncarew]

and, /cc'ing @jmesserly, for the DDC / DDK question

[devoncarew]

Actually, to see the repro, you need to switch the default for --use-fasta-parser in the command line analyzer's options.dart file, delete the sdk's build cache, and then try and re-build the sdk.

[jmesserly]

I can take a look, thanks for letting me know!

Those errors look like the imports/part-of are not working in the SDK. In particular:

[error] Target of URI doesn't exist: 'classes.dart'. (dart:_runtime, line 33, col 6)

this means we fail to resolve part "classes.dart" from dart:_runtime ... that should look for a URI dart:_runtime/classes.dart and find it via the DartUriResolver. At least that's how it works in Analyzer right now. In dartdevk DDC sets up CFE with libraries.json, that's how SDK URIs are resolved.

How does URI resolution work when Analyzer is configured to useFastaParser? I can try to debug it and see what's going on.

Another question: does Analyzer support @patch when run with the CFE parser?

[jmesserly]

fyi -- I will be out for 3 weeks starting Monday. So I'll see if I can figure this out today. :)

[devoncarew]

How does URI resolution work when Analyzer is configured to useFastaParser? I can try to debug it and see what's going on.

I don't know for sure, but would suspect that the uri resolution is the same (that switching the parser doesn't change how we do resolution).

Another question: does Analyzer support @patch when run with the CFE parser?

@danrubel, do you know?

[jmesserly]

I haven't been able to reproduce this by setting the flag on AnalysisOptionsImpl (and cleaning my build output) ... is it possible I need to patch in the full CL?

Is there somewhere in Analyzer that I can add a print statement to see if the CFE parser is kicking in?