Skip to content

getters_setters2_test needs triage #34365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MichaelRFairhurst opened this issue Sep 4, 2018 · 2 comments
Open

getters_setters2_test needs triage #34365

MichaelRFairhurst opened this issue Sep 4, 2018 · 2 comments
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@MichaelRFairhurst
Copy link
Contributor

This is not an effective test right now for the analyzer:

class T2 {                                                                       
  A getterField;                                                                 
  C setterField;                                                                 
  A get field {                                                                  
    return getterField;                                                          
  }                                                                              
                                                                                 
  // Type C is not assignable to A                                               
  void set field(C arg) { setterField = arg; } //# 01: static type warning       
}

We actually get an error on A get field. This means our status file is:

getters_setters2_test/01: CompileTimeError 

because A get field only fails on test case 01, and CompileTimeError supercedes MissingCompileTimeError?

But this is not a good test of the actual issue.

Maybe its as simple as moving the //# 01 case up to A get field, but I'm filing an issue because test changes are so tedious.

@MichaelRFairhurst MichaelRFairhurst added the area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). label Sep 4, 2018
@MichaelRFairhurst MichaelRFairhurst self-assigned this Sep 4, 2018
@eernstg
Copy link
Member

eernstg commented Sep 5, 2018

Note also #34349 which makes this error a warning (along with several others).

@eernstg
Copy link
Member

eernstg commented Oct 4, 2018

This CL adjusts dartLangSpec.tex such that the compile-time error mentioned above is changed to a warning.

dart-bot pushed a commit that referenced this issue Oct 24, 2018
Partially resolves issue #34349.
Also note that #34365 and #34319 are affected by this change.

Change-Id: I1d9023464090ff2c07f9dc062353202ddb82ba25
Reviewed-on: https://dart-review.googlesource.com/c/78121
Reviewed-by: Leaf Petersen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Development

No branches or pull requests

2 participants