move dartdevc off analyzer task model #35013
Assignees
Labels
P1
A high priority bug; for example, a single project is unusable or has many test failures
web-dev-compiler
Milestone
Comments
jmesserly
added
the
P1
This was referenced Oct 31, 2018
|
@JekCharlsonYu - we're hoping to cherry-pick this fix for 2.1. It fixes some issues @yjbanov hit on new mixins. |
|
@jmesserly has fix she's testing now. |
|
I'm testing this CL: https://dart-review.googlesource.com/c/sdk/+/82469. I may need to update a more status entries, but otherwise I think it's in good shape. edit: CL out for review. |
|
@jmesserly - how is this looking? |
|
I believe we can land CL https://dart-review.googlesource.com/c/sdk/+/82469 but I'll need to keep working on the debugger extension console (an internal test failing -- though it was already failing from an unrelated command line options change). |
dart-bot
pushed a commit
that referenced
this issue
Nov 6, 2018
Original commit message:
[dartdevc] fix #35013, move DDC off Analyzer task model
The new file pkg/dev_compiler/lib/src/analyzer/driver.dart handles
building the linked summary for a build unit, and then is capable of
doing analysis using LibraryAnalyzer.
The algorithm is very similar to analyzer_cli's build mode. The
biggest difference is that `dartdevc` has existing support for
discovering source files from the explicit source list (rather than
requiring every source to be listed on the command line). We don't want
to break that support, so there's a bit of logic to follow imports,
exports, and parts.
After the linked summary is produced, DDC gets the analysis results
(errors and resolved AST) for each library, and compiles it into a JS
module.
Change-Id: I8d1855c27f9976cad6fd9ccb567b75a613e6048c
Reviewed-on: https://dart-review.googlesource.com/c/83060
Commit-Queue: Paul Berry <[email protected]>
Auto-Submit: Paul Berry <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
dart-bot
pushed a commit
that referenced
this issue
Nov 7, 2018
The new file pkg/dev_compiler/lib/src/analyzer/driver.dart handles building the linked summary for a build unit, and then is capable of doing analysis using LibraryAnalyzer. The algorithm is very similar to analyzer_cli's build mode. The biggest difference is that `dartdevc` has existing support for discovering source files from the explicit source list (rather than requiring every source to be listed on the command line). We don't want to break that support, so there's a bit of logic to follow imports, exports, and parts. After the linked summary is produced, DDC gets the analysis results (errors and resolved AST) for each library, and compiles it into a JS module. Change-Id: I7bf1ce1eca73fd036002e498de5924c488b534dc Reviewed-on: https://dart-review.googlesource.com/c/82469 Commit-Queue: Jenny Messerly <[email protected]> Reviewed-by: Paul Berry <[email protected]> Reviewed-by: Vijay Menon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See #33546
Also, Analyzer task model has incorrect results for some things (e.g. mixin type arguments, top-level inference) and users are hitting these.
The text was updated successfully, but these errors were encountered: