Skip to content

(Set Literals) Analyzer Issue #35120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
9 tasks done
JekCharlsonYu opened this issue Nov 9, 2018 · 5 comments
Closed
9 tasks done

(Set Literals) Analyzer Issue #35120

JekCharlsonYu opened this issue Nov 9, 2018 · 5 comments
Assignees
Labels
legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Milestone

Comments

@JekCharlsonYu
Copy link
Contributor

JekCharlsonYu commented Nov 9, 2018

***** Request:
As per implementation Plan:
Task3 : Task1 (Analyzer implementation)
The analyzer implements static checking for set literals (errors and wrarnings, constant evaluation).


Tracked in this Issue
Implementation Plan, see ETA in this issue too.
Full proposal

Tasks:

@JekCharlsonYu JekCharlsonYu added the legacy-area-analyzer Use area-devexp instead. label Nov 9, 2018
@JekCharlsonYu JekCharlsonYu added this to the Dart2.2 milestone Nov 9, 2018
@bwilkerson bwilkerson self-assigned this Nov 9, 2018
@stereotype441 stereotype441 added type-enhancement A request for a change that isn't a bug P2 A bug or feature request we're likely to work on labels Nov 13, 2018
@bwilkerson
Copy link
Member

There is one bug left, which I believe is more general than the set literals feature, in which some type inference cases are not being handled correctly.

@stereotype441
Copy link
Member

Note: the one remaining language_2 test failure should be fixed by https://dart-review.googlesource.com/c/sdk/+/88601

@stereotype441
Copy link
Member

Analyzer work is done.

@stereotype441
Copy link
Member

Reopening as a reminder to fix failing tests once the feature lands

@stereotype441 stereotype441 reopened this Feb 7, 2019
@stereotype441
Copy link
Member

Failing tests have been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants