Skip to content

Analyzer tests need to be updated once set literals are enabled by default #35870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stereotype441 opened this issue Feb 6, 2019 · 1 comment
Closed

Analyzer tests need to be updated once set literals are enabled by default #35870

stereotype441 opened this issue Feb 6, 2019 · 1 comment
Assignees
@stereotype441
Labels
legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@stereotype441
Copy link
Member

https://dart-review.googlesource.com/c/sdk/+/92125 is the CL to enable set literals support. This causes a small number of analyzer test failures (marked with @failingTest in the CL). I suspect these failures are not due to real bugs, but rather due to tests making assumptions that will no longer be satisfied once set literals are enabled (e.g. assuming that {} in a context expecting Iterable will result in an error). Assuming this is the case, the tests should be fixed and the @failingTest annotation should be removed.

If any of the failures are due to real bugs, those bugs will need to be fixed.
@stereotype441 stereotype441 added legacy-area-analyzer Use area-devexp instead. type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable P2 A bug or feature request we're likely to work on labels Feb 6, 2019
@stereotype441
Copy link
Member Author

@bwilkerson FYI

@JekCharlsonYu JekCharlsonYu mentioned this issue Feb 7, 2019
Closed
9 tasks
@stereotype441 stereotype441 self-assigned this Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stereotype441 stereotype441

Labels
legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stereotype441