Skip to content

Please merge cb883470871af88a4ffba54f5d2cadf6eb7fa315 and e4a5ab06e4c128d3440caad00e4d4196a80a1c72 into stable channel #35232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stereotype441 opened this issue Nov 20, 2018 · 5 comments
Labels
Milestone

Comments

@stereotype441
Copy link
Member

@whesse @mit-mit @kasperl

This provides a minimal implementation of #35162 for Dart 2.1.1. Namely, it causes a hint to be shown if the user attempts to use Future or Stream without importing dart:async, and their pubspec indicates that they support a version of the SDK prior to those symbols being exported from dart:core.

The implementation addresses just the first two checkboxes from #35162. That is, it does not include logic to trigger re-analysis of the hint if the pubspec changes, and it does not include quick fixes to allow the user to correct the hint with a few clicks.

Revisions to be merged:

Note: these CLs cherry-pick cleanly to stable, but they result in an SDK that is unbuildable due to an extraneous import. See https://dart-review.googlesource.com/c/sdk/+/84980 for the proper fix to the conflict.

@whesse
Copy link
Contributor

whesse commented Nov 21, 2018

@athomas @JekCharlsonYu

@stereotype441
Copy link
Member Author

Note that we may not want to cherry-pick this until #35290 is fixed.

@bwilkerson
Copy link
Member

#35290 has been fixed by https://dart-review.googlesource.com/c/sdk/+/85620, so as long as we also cherry pick that fix, we should be good to go.

@stereotype441
Copy link
Member Author

Ok, I've updated https://dart-review.googlesource.com/c/sdk/+/84980 to include a cherry-pick of https://dart-review.googlesource.com/c/sdk/+/85620, so landing that CL should now be a sufficient fix.

@athomas
Copy link
Member

athomas commented Feb 20, 2019

Even though we haven't cherry-picked this, it was included in the full pushes we did for 2.1.1.

@athomas athomas closed this as completed Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants