Skip to content

Detection of SDK constraint violation has a false positive with references in combinators #35290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bwilkerson opened this issue Nov 29, 2018 · 2 comments
Closed

Detection of SDK constraint violation has a false positive with references in combinators #35290

bwilkerson opened this issue Nov 29, 2018 · 2 comments
Assignees
@bwilkerson
Labels
legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Milestone
Dart 2.1.1

Comments

@bwilkerson
Copy link
Member

References to Future and Stream that occur in combinators should not be flagged. Even if the classes are inappropriately in the namespace via dart:core, the issue will be flagged at the use site.

To reproduce, create a file containing

export 'dart:async' show Future;
@bwilkerson bwilkerson added P1 A high priority bug; for example, a single project is unusable or has many test failures legacy-area-analyzer Use area-devexp instead. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Nov 29, 2018
@bwilkerson bwilkerson self-assigned this Nov 29, 2018
@bwilkerson bwilkerson added this to the Dart2.1.1 milestone Nov 29, 2018
@stereotype441
Copy link
Member

Note: this issue is in the Dart2.1.1 milestone because it is a bug in #35162, which we are currently trying to cherry-pick to 2.1.1 (see cherry-pick request #35232).

@stereotype441 stereotype441 mentioned this issue Nov 29, 2018
Closed
@bwilkerson
Copy link
Member Author

https://dart-review.googlesource.com/c/sdk/+/85620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwilkerson bwilkerson

Labels
legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
Dart 2.1.1
Development

No branches or pull requests
2 participants
@stereotype441 @bwilkerson