Provide optimized implementation in core library for const and non-const set literals (like _ImmutableMap and Map._fromLiteral) #36077
Assignees
Labels
area-vm
Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
type-enhancement
A request for a change that isn't a bug
Comments
a-siva
added
area-vm
dart-bot
pushed a commit
that referenced
this issue
Jul 8, 2021
In separate CL so that the LinkedHashMap CL is a bit smaller. Bug: #36077 TEST=tests/**_test.dart Change-Id: I4ecff40a40fffbad4d9c37ca426066128c0ed7f7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206223 Reviewed-by: Tess Strickland <[email protected]> Commit-Queue: Daco Harkes <[email protected]>
dart-bot
pushed a commit
that referenced
this issue
Jul 12, 2021
`_CompactLinkedHashSet` now extends `_HashVMBase`. The class hierarchy is organized as mixins similar to LinkedHashMap to accomodate for the other Sets not extending `_HashVMBase`. Also, rearranges some code so that introducing ImmutableHashMap and ImmutableHashSet is easier. 1) snapshot.h and snapshot.cc now have a MapReadFrom, MapWriteTo, SetReadFrom, and SetWriteTo to facilitate code sharing between mutable and immutable implementations similar to ArrayReadFrom and ArrayWriteTo. 2) Macros for CLASS_LIST_MAPS and CLASS_LIST_SETS to facilitate treating mutable and immutable implementations with the same handle. Also similar to Array. Clustered snapshots for HashMaps is currently dead code. This CL makes it explicit by marking these as unreachable. Immutable maps and sets will end up in the clustered snapshot in follow up CLs. Bug: #36077 Bug: #45908 TEST=runtime/vm/object_test.cc TEST=tests/**_test.dart on many bots Change-Id: If3cc5ebb3138535aeb0d5e06d9da3d1c9fb2deb2 Cq-Include-Trybots: luci.dart.try:analyzer-nnbd-linux-release-try,app-kernel-linux-debug-x64-try,dart-sdk-linux-try,front-end-nnbd-linux-release-x64-try,pkg-linux-debug-try,vm-canary-linux-debug-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-checked-linux-release-x64-try,vm-kernel-linux-debug-x64c-try,vm-kernel-linux-debug-x64-try,vm-kernel-linux-debug-simarm64c-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-optcounter-threshold-linux-release-x64-try,vm-kernel-precomp-android-release-arm_x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64c-try,vm-kernel-reload-linux-debug-x64-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-kernel-precomp-linux-release-simarm_x64-try,vm-kernel-precomp-linux-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206222 Reviewed-by: Tess Strickland <[email protected]> Reviewed-by: Ben Konyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If it makes sense provide optimized implementations in core library for const and non-const set literals (like _ImmutableMap and Map._fromLiteral)
The text was updated successfully, but these errors were encountered: