Skip to content

Make constant-update-2018 work for split-kernel apps #36639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zanderso opened this issue Apr 15, 2019 · 1 comment
Closed

Make constant-update-2018 work for split-kernel apps #36639

zanderso opened this issue Apr 15, 2019 · 1 comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. closed-duplicate Closed in favor of an existing report customer-fuchsia type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@zanderso
Copy link
Member

Currently, through a mechanism that I have not investigated, the Dart VM crashes with allocations of unreasonable size in the dart_runner running tests on Fuchsia when constant-update-2018 is enabled.

To reproduce:

  1. Remove the flag --enable-experiment=no-constant-update-2018 from //topaz/runtime/dart/dart_kernel.gni
  2. Configure a build with e.g.:
$ fx --dir out/topaz-arm64-debug set core.frank --with-base //topaz/bundles:buildbot
  1. Run tests with:
$ fx shell runtests
  1. Note that tests fail. They fail due to failing to map unreasonably large vmos. To see these enable logging in runtime/vm/virtual_memory_fuchsia.cc

@alexmarkov @a-siva @rmacnak-google @aartbik
@zanderso zanderso added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) customer-fuchsia labels Apr 15, 2019
@a-siva
Copy link
Contributor

a-siva commented Apr 15, 2019

This is a duplicate of #36584

@zanderso zanderso added the closed-duplicate Closed in favor of an existing report label Apr 15, 2019
@a-siva a-siva closed this as completed Apr 15, 2019
creatint pushed a commit to creatint/topaz that referenced this issue Mar 3, 2020
@zanderso
[dart] Disable constant-update-2018 experiment
18d03d9 
See: dart-lang/sdk#36639

Change-Id: I3b5bb4b032936776022f78bf22c4bd2b5bb7f0d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. closed-duplicate Closed in favor of an existing report customer-fuchsia type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zanderso @a-siva