Skip to content

Migrate dart:ffi and its tests to NNBD #40041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
leafpetersen opened this issue Jan 9, 2020 · 1 comment
Closed

Migrate dart:ffi and its tests to NNBD #40041

leafpetersen opened this issue Jan 9, 2020 · 1 comment
Assignees
@dcharkes
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. NNBD Issues related to NNBD Release

Comments

@leafpetersen
Copy link
Member

This tracks the migration of dart:ffi and related tests to NNBD.
@leafpetersen leafpetersen added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. NNBD Issues related to NNBD Release labels Jan 9, 2020
@leafpetersen
Copy link
Member Author

Looks like this is already tracked here . closing as a dup.

copybara-service bot pushed a commit that referenced this issue Oct 24, 2023
@natebosch
Remove some now unnecessary casts
7ba47c6 
Flow analysis has improved and issue #40041 is resolved. These
`FutureOr<T>` conditionals are promoting to `Future<T>` or `T` and no
longer need an explicit cast.

[email protected]

Change-Id: I925db6d7f52aad54c88434ff02e1d0ae4e72278b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331206
Reviewed-by: Lasse Nielsen <[email protected]>
Commit-Queue: Ömer Ağacan <[email protected]>
Reviewed-by: Stephen Adams <[email protected]>
Reviewed-by: Sigmund Cherem <[email protected]>
Auto-Submit: Nate Bosch <[email protected]>
Reviewed-by: Martin Kustermann <[email protected]>
Reviewed-by: Ömer Ağacan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcharkes dcharkes

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. NNBD Issues related to NNBD Release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dcharkes @leafpetersen