Skip to content

Unforked Null Safe SDK #40105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
franklinyow opened this issue Jan 13, 2020 · 3 comments
Closed

Unforked Null Safe SDK #40105

franklinyow opened this issue Jan 13, 2020 · 3 comments
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). Epic NNBD Issues related to NNBD Release
Milestone
D29 Release

Comments

@franklinyow
Copy link
Contributor

franklinyow commented Jan 13, 2020 •
edited by a-siva
Loading

Tracks work associated with achieving feature and performance parity running unmigrated code against the Null Safe SDK.

Meta tracking issue for VM for this work is #40179
@franklinyow franklinyow added Epic NNBD Issues related to NNBD Release labels Jan 13, 2020
@franklinyow franklinyow added this to the D28 Release milestone Jan 14, 2020
@mit-mit mit-mit added the area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). label Jan 15, 2020
@jcollins-g jcollins-g mentioned this issue Mar 26, 2020
Closed
@vsmenon
Copy link
Member

vsmenon commented Apr 9, 2020

@franklinyow - is this still the primary issue? We're still missing:

  • dart2js test failure on unfork cl
  • dart:_http breakage
  • internal run
  • flutter run
  • dart2js performance
  • dart2js code size
  • aot code size (need flutter gallery size numbers)

@franklinyow
Copy link
Contributor Author

@franklinyow - is this still the primary issue? We're still missing:

  • dart2js test failure on unfork cl
  • dart:_http breakage
  • internal run
  • flutter run
  • dart2js performance
  • dart2js code size
  • aot code size (need flutter gallery size numbers)

This Epic will close as soon as the ddc work landed.
The unforking work is in #40106

@vsmenon
Copy link
Member

vsmenon commented Apr 9, 2020

That does not seem right. 40106 is post-unfork completeness work. We still need the above to actually unfork (i.e., land @a-siva 's cl): https://dart-review.googlesource.com/c/sdk/+/138902

@mit-mit mit-mit modified the milestones: D28 Release, D29 Release May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). Epic NNBD Issues related to NNBD Release
Projects
None yet
Milestone
D29 Release
Development

No branches or pull requests
3 participants
@vsmenon @mit-mit @franklinyow