Skip to content

VM should support unforked Null Safe SDK #40179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
a-siva opened this issue Jan 16, 2020 · 2 comments
Closed

VM should support unforked Null Safe SDK #40179

a-siva opened this issue Jan 16, 2020 · 2 comments
Assignees
@a-siva
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. Epic NNBD Issues related to NNBD Release vm-nnbd-unfork-sdk Label for all issues that need to be done before the nnbd sdk can be unforked
Milestone
D28 Release

Comments

@a-siva
Copy link
Contributor

a-siva commented Jan 16, 2020 •
edited
Loading

This is the meta issue to track all issues that need to be addressed before we claim that the VM can support unforking of the Null Safe SDK.

Dependent issues -

NNBD support in Dart API #40176
NNBD Legacy mode test failures in co19_2/Language/Generics/typedef_A04 #40171
NNBD Legacy mode test failure in dart_api_impl_test.cc #40170
NNBD Legacy mode test failures in snapshot_test.cc #40169
Migrate dart:vmservice to NNBD #40046
Migrate dart:mirrors and tests to NNBD #40045
Migrate dart:cli and tests to NNBD #40044
Migrate dart:isolate and tests to NNBD #40042
Migrate dart:io and its tests to NNBD #40040
Error accessing static field from nested function #39929
type '_Invocation' is not a subtype of type '_InvocationMirror' in type cast #39815
Implementation of NNBD runtime checks for weak mode support #39755
Migrate patch files in core libraries and dart:io library to be NNBD clean #39754
Dart ignores non-nullability of variables and function parameters. #39678
NNBD. Dart ignores required named parameters #39660
Required Named Parameters in VM #38843
Migrate VM libraries to NNBD Epic #38037
Replace the SDK platform libraries with the NNBD migrated version #37929
Migrate core libraries to NNBD #37928
NNBD platform library migration Epic #37926
@a-siva a-siva added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. Epic NNBD Issues related to NNBD Release labels Jan 16, 2020
@a-siva a-siva self-assigned this Jan 16, 2020
@a-siva a-siva added the vm-nnbd-unfork-sdk Label for all issues that need to be done before the nnbd sdk can be unforked label Jan 16, 2020
@franklinyow franklinyow mentioned this issue Jan 16, 2020
Closed
@franklinyow franklinyow added Epic and removed Epic labels Jan 20, 2020
@franklinyow franklinyow added this to the D28 Release milestone Jan 21, 2020
dart-bot pushed a commit that referenced this issue Jan 28, 2020
@liamappelbe
[vm] Set non_nullable_flag() to true
61b4bbc 
We'll leave the deletion and cleanup of this function until later, so
that this CL is as easy to rollback as possible.

Bug: #40179
Change-Id: Ie583aaabd117ae06ea27a539c3bc904240a0e6bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133429
Reviewed-by: Siva Annamalai <[email protected]>
Commit-Queue: Liam Appelbe <[email protected]>
dart-bot pushed a commit that referenced this issue Jan 30, 2020
@liamappelbe
Revert "[vm] Set non_nullable_flag() to true"
bf5278b 
This reverts commit 61b4bbc.

Reason for revert: Performance regressions

Original change's description:
> [vm] Set non_nullable_flag() to true
> 
> We'll leave the deletion and cleanup of this function until later, so
> that this CL is as easy to rollback as possible.
> 
> Bug: #40179
> Change-Id: Ie583aaabd117ae06ea27a539c3bc904240a0e6bc
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133429
> Reviewed-by: Siva Annamalai <[email protected]>
> Commit-Queue: Liam Appelbe <[email protected]>

[email protected],[email protected]

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: #40179
Change-Id: I7e1d81286d769faeacec7dc17612ff18d157f114
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134060
Reviewed-by: Liam Appelbe <[email protected]>
Commit-Queue: Liam Appelbe <[email protected]>
dart-bot pushed a commit that referenced this issue Jan 30, 2020
@liamappelbe
[vm] Reland the flag flip behind the --nnbd build flag
00e481a 
Bug: #40409
Bug: #40179
Change-Id: Ib84926ef15068d23dcac7b89843c454b8446b28e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134062
Reviewed-by: Siva Annamalai <[email protected]>
Commit-Queue: Liam Appelbe <[email protected]>
dart-bot pushed a commit that referenced this issue Feb 6, 2020
@liamappelbe
[vm] Reland NNBD flag flip
130de1a 
Bug: #40179
Change-Id: I3ab5e1f5a0ee69e9850910eee59611eb4583e498
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134601
Reviewed-by: Siva Annamalai <[email protected]>
Commit-Queue: Liam Appelbe <[email protected]>
@franklinyow
Copy link
Contributor

Looks like this is done. Can I close this?

@franklinyow
Copy link
Contributor

closing it as all issues completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-siva a-siva

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. Epic NNBD Issues related to NNBD Release vm-nnbd-unfork-sdk Label for all issues that need to be done before the nnbd sdk can be unforked
Projects
None yet
Milestone
D28 Release
Development

No branches or pull requests
2 participants
@a-siva @franklinyow