Skip to content

NNBD Legacy mode test failure in dart_api_impl_test.cc #40170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
liamappelbe opened this issue Jan 15, 2020 · 0 comments
Closed

NNBD Legacy mode test failure in dart_api_impl_test.cc #40170

liamappelbe opened this issue Jan 15, 2020 · 0 comments
Assignees
@liamappelbe
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release vm-nnbd-unfork-sdk Label for all issues that need to be done before the nnbd sdk can be unforked
Milestone
D28 Release

Comments

@liamappelbe
Copy link
Contributor

The DartAPI_TypeGetParameterizedTypes test in dart_api_impl_test.cc is failing in NNBD legacy mode (when force enabling non_nullable_flag, but not enabling the experiment flag).

The failure is to do with the Dart_IdentityEquals function.

Logs: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8891173016667186608/+/steps/test_results/0/logs/new_test_failures__logs_/0
@liamappelbe liamappelbe added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release labels Jan 15, 2020
@liamappelbe liamappelbe assigned a-siva and liamappelbe and unassigned a-siva Jan 15, 2020
@a-siva a-siva added the vm-nnbd-unfork-sdk Label for all issues that need to be done before the nnbd sdk can be unforked label Jan 16, 2020
@a-siva a-siva mentioned this issue Jan 16, 2020
Closed
@franklinyow franklinyow reopened this Jan 20, 2020
@franklinyow franklinyow added this to the D28 Release milestone Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liamappelbe liamappelbe

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release vm-nnbd-unfork-sdk Label for all issues that need to be done before the nnbd sdk can be unforked
Projects
None yet
Milestone
D28 Release
Development

No branches or pull requests
3 participants
@liamappelbe @a-siva @franklinyow