Skip to content

Required Named Parameters in VM #38843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
liamappelbe opened this issue Oct 11, 2019 · 3 comments
Closed

Required Named Parameters in VM #38843

liamappelbe opened this issue Oct 11, 2019 · 3 comments
Assignees
@liamappelbe
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release
Milestone
D28 Release

Comments

@liamappelbe
Copy link
Contributor

CFE is populating an isRequired flag on function parameters. We need to support this flag in the VM.

Part of #37479
@liamappelbe liamappelbe added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release labels Oct 11, 2019
@liamappelbe liamappelbe self-assigned this Dec 20, 2019
@a-siva a-siva added the vm-nnbd-unfork-sdk Label for all issues that need to be done before the nnbd sdk can be unforked label Jan 16, 2020
@a-siva a-siva mentioned this issue Jan 16, 2020
Closed
@franklinyow franklinyow added this to the D28 Release milestone Jan 21, 2020
@franklinyow
Copy link
Contributor

Any update?

@alexmarkov alexmarkov removed the vm-nnbd-unfork-sdk Label for all issues that need to be done before the nnbd sdk can be unforked label Feb 25, 2020
@liamappelbe
Copy link
Contributor Author

Working on it. Mailing the first CL today. This doesn't block unforking though.

@franklinyow
Copy link
Contributor

If this does not block unforking, please take a look and decide if this could be moved under #40106 or #40107.

dart-bot pushed a commit that referenced this issue Mar 2, 2020
@liamappelbe
[vm] Check required flag during function resolution.
149b799 
Bug: #39660
Bug: #38843
Change-Id: I2eb5f5ac38d7b1896db5c57399c42cdb41b16094
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137737
Commit-Queue: Liam Appelbe <[email protected]>
Reviewed-by: Alexander Markov <[email protected]>
Reviewed-by: Régis Crelier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liamappelbe liamappelbe

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release
Projects
None yet
Milestone
D28 Release
Development

No branches or pull requests
4 participants
@liamappelbe @a-siva @alexmarkov @franklinyow