Skip to content

Migrate patch files in core libraries and dart:io library to be NNBD clean #39754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
a-siva opened this issue Dec 12, 2019 · 1 comment
Closed

Migrate patch files in core libraries and dart:io library to be NNBD clean #39754

a-siva opened this issue Dec 12, 2019 · 1 comment
Assignees
@mkustermann @a-siva
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release vm-nnbd-unfork-sdk Label for all issues that need to be done before the nnbd sdk can be unforked
Milestone
D28 Release

Comments

@a-siva
Copy link
Contributor

a-siva commented Dec 12, 2019

This issue is a tracker for migrating the patch files in core libraries and migrating dart:io code to be NNBD clean.
@a-siva a-siva added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release labels Dec 12, 2019
@a-siva a-siva added this to the D28 Release milestone Dec 12, 2019
@a-siva a-siva self-assigned this Dec 12, 2019
@aadilmaan aadilmaan mentioned this issue Dec 12, 2019
Closed
7 tasks
@mkustermann mkustermann self-assigned this Dec 16, 2019
dart-bot pushed a commit that referenced this issue Jan 2, 2020
@mkustermann
[vm/nnbd] First start on migrating VM patch files for NNBD
4e9a8c8 
Issue #39754

Change-Id: Id0322ee6bde9b3af5483feacf73b590cdafbc62d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127160
Commit-Queue: Martin Kustermann <[email protected]>
Reviewed-by: Lasse R.H. Nielsen <[email protected]>
dart-bot pushed a commit that referenced this issue Jan 9, 2020
@mkustermann
[vm/nnbd] Second set of changes for migrating VM patch files for NNBD
eeca7c5 
Issue #39754

Change-Id: Icfbeed29a2c81c3b118686a14071d5156452e352
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130370
Commit-Queue: Martin Kustermann <[email protected]>
Reviewed-by: Lasse R.H. Nielsen <[email protected]>
@a-siva a-siva added the vm-nnbd-unfork-sdk Label for all issues that need to be done before the nnbd sdk can be unforked label Jan 16, 2020
@a-siva a-siva mentioned this issue Jan 16, 2020
Closed
@franklinyow franklinyow modified the milestones: D29 Release, D28 Release Jan 21, 2020
@a-siva
Copy link
Contributor Author

a-siva commented Jan 30, 2020

All patch files of core libraries in the VM have been migrated.
dart:io migration is being tracked in #40040

@a-siva a-siva closed this as completed Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkustermann mkustermann

@a-siva a-siva

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release vm-nnbd-unfork-sdk Label for all issues that need to be done before the nnbd sdk can be unforked
Projects
None yet
Milestone
D28 Release
Development

No branches or pull requests
3 participants
@mkustermann @a-siva @franklinyow