Skip to content

NNBD Legacy mode test failures in snapshot_test.cc #40169

Closed
@liamappelbe

Description

@liamappelbe

Several tests in snapshot_test.cc are failing in NNBD legacy mode (when force enabling non_nullable_flag, but not enabling the experiment flag).

The failures are all due to Dart_CObject that are supposed to have type Dart_CObject_kArray but actually have type Dart_CObject_kUnsupported. Presumably there's some internal type check that's being confused by the legacy nnbd type.

Logs: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8891173016667186608/+/steps/test_results/0/logs/new_test_failures__logs_/0

Metadata

Metadata

Assignees

Labels

NNBDIssues related to NNBD Releasearea-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.vm-nnbd-unfork-sdkLabel for all issues that need to be done before the nnbd sdk can be unforked

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions