Skip to content

NNBD Legacy mode test failures in snapshot_test.cc #40169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liamappelbe opened this issue Jan 15, 2020 · 1 comment
Closed

NNBD Legacy mode test failures in snapshot_test.cc #40169

liamappelbe opened this issue Jan 15, 2020 · 1 comment
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release vm-nnbd-unfork-sdk Label for all issues that need to be done before the nnbd sdk can be unforked
Milestone

Comments

@liamappelbe
Copy link
Contributor

liamappelbe commented Jan 15, 2020

Several tests in snapshot_test.cc are failing in NNBD legacy mode (when force enabling non_nullable_flag, but not enabling the experiment flag).

The failures are all due to Dart_CObject that are supposed to have type Dart_CObject_kArray but actually have type Dart_CObject_kUnsupported. Presumably there's some internal type check that's being confused by the legacy nnbd type.

Logs: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8891173016667186608/+/steps/test_results/0/logs/new_test_failures__logs_/0

@liamappelbe liamappelbe added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release labels Jan 15, 2020
@a-siva a-siva added the vm-nnbd-unfork-sdk Label for all issues that need to be done before the nnbd sdk can be unforked label Jan 16, 2020
@liamappelbe liamappelbe assigned liamappelbe and unassigned a-siva Jan 16, 2020
@liamappelbe
Copy link
Contributor Author

This is to do with passing dart objects as serialized messages. The issue is that the native message reader and writer (ApiMessageReader/ApiMessageWriter) only support a small number of types. In particular, for generic types like List, it only supports ints, doubles, and strings as T. So it gets confused when it sees List<int*>, an int with legacy nnbd flag.

Fixing this is a pretty big job involving extending the API, so this is part of #40176.

@franklinyow franklinyow added this to the D28 Release milestone Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release vm-nnbd-unfork-sdk Label for all issues that need to be done before the nnbd sdk can be unforked
Projects
None yet
Development

No branches or pull requests

3 participants