Flow graph check hits assertion failures in several service tests running in AOT mode

[rmacnak-google]

[ $compiler == dartkp && $mode == debug ]
async_single_step_into_test: Crash
async_single_step_out_test: Crash
async_star_single_step_into_test: Crash
async_star_step_out_test: Crash
async_step_out_test: Crash
awaiter_async_stack_contents_2_test: Crash
causal_async_stack_contents_test: Crash
causal_async_stack_presence_test: Crash
causal_async_star_stack_presence_test: Crash
next_through_simple_async_test: Crash
next_through_simple_async_with_returns_test: Crash
next_through_simple_async_with_returns_test: Crash
pause_on_unhandled_async_exceptions2_test: Crash
pause_on_unhandled_async_exceptions_test: Crash

../../runtime/vm/compiler/backend/flow_graph_checker.cc: 146: error: expected: (arg_def == env_def) || (arg_def->IsConstant() && env_def->IsConstant() &&
arg_def->AsConstant()->value().raw() == env_def->AsConstant()->value().raw())
version=2.8.0-edge.cede434cd9aff91c7e228dece1d67c8a27730030 (Tue Jan 21 17:22:14 2020 -0800) on "linux_x64"
thread=151560, isolate=isolate(0x564f1a643800)
  pc 0x0000564f194ba55c fp 0x00007ffca0d83520 dart::Profiler::DumpStackTrace(void*)
  pc 0x0000564f1922cc02 fp 0x00007ffca0d83600 dart::Assert::Fail(char const*, ...)
  pc 0x0000564f19606c3f fp 0x00007ffca0d83660 out/DebugX64/gen_snapshot+0x9eec3f
  pc 0x0000564f19606d55 fp 0x00007ffca0d83690 dart::FlowGraphChecker::VisitPolymorphicInstanceCall(dart::PolymorphicInstanceCallInstr*)
  pc 0x0000564f196059c3 fp 0x00007ffca0d836f0 dart::FlowGraphChecker::VisitInstruction(dart::Instruction*)
  pc 0x0000564f19605505 fp 0x00007ffca0d83760 dart::FlowGraphChecker::VisitInstructions(dart::BlockEntryInstr*)
  pc 0x0000564f19604f1c fp 0x00007ffca0d837e0 dart::FlowGraphChecker::VisitBlocks()
  pc 0x0000564f196f693a fp 0x00007ffca0d83880 dart::CompilerPass::Run(dart::CompilerPassState*) const
  pc 0x0000564f196f6a9d fp 0x00007ffca0d838a0 dart::CompilerPass::RunInliningPipeline(dart::CompilerPass::PipelineMode, dart::CompilerPassState*)
  pc 0x0000564f1968e8c5 fp 0x00007ffca0d83db0 out/DebugX64/gen_snapshot+0xa768c5
  pc 0x0000564f1969e59d fp 0x00007ffca0d83ea0 out/DebugX64/gen_snapshot+0xa8659d
  pc 0x0000564f19696ba4 fp 0x00007ffca0d83fc0 out/DebugX64/gen_snapshot+0xa7eba4
  pc 0x0000564f19696722 fp 0x00007ffca0d840b0 dart::FlowGraphInliner::Inline()
  pc 0x0000564f196f70e4 fp 0x00007ffca0d84110 out/DebugX64/gen_snapshot+0xadf0e4
  pc 0x0000564f196f6833 fp 0x00007ffca0d841b0 dart::CompilerPass::Run(dart::CompilerPassState*) const
  pc 0x0000564f196f6ce0 fp 0x00007ffca0d841e0 dart::CompilerPass::RunPipeline(dart::CompilerPass::PipelineMode, dart::CompilerPassState*)
  pc 0x0000564f195a6b30 fp 0x00007ffca0d84850 dart::PrecompileParsedFunctionHelper::Compile(dart::CompilationPipeline*)
  pc 0x0000564f195a939f fp 0x00007ffca0d84a60 out/DebugX64/gen_snapshot+0x99139f
  pc 0x0000564f195a400e fp 0x00007ffca0d84b00 dart::Precompiler::CompileFunction(dart::Precompiler*, dart::Thread*, dart::Zone*, dart::Function const&)
  pc 0x0000564f195a23bb fp 0x00007ffca0d84b70 dart::Precompiler::ProcessFunction(dart::Function const&)
  pc 0x0000564f1959d523 fp 0x00007ffca0d84ba0 dart::Precompiler::Iterate()
  pc 0x0000564f1959a55c fp 0x00007ffca0d84d60 dart::Precompiler::DoCompileAll()
  pc 0x0000564f19599e15 fp 0x00007ffca0d85190 dart::Precompiler::CompileAll()
  pc 0x0000564f19a213bb fp 0x00007ffca0d85250 Dart_Precompile
  pc 0x0000564f1920232c fp 0x00007ffca0d853e0 dart::bin::main(int, char**)

[mkustermann]

@alexmarkov Maybe this is a similar case as #40189 (caused by the arguments refactoring)

[alexmarkov]

@mkustermann Yes, maybe its a yet another IL inconsistency or bug uncovered by the more strict flow graph checking after PushArguments were removed.

[alexmarkov]

It turns out this is a duplicate to #40189. The crash disappeared at feb73b2, but was crashing on the commit before.